Fix and test create support

Author: dunglas

features/graphql/mutation.feature

@@ -91,7 +91,6 @@ Feature: GraphQL mutation support
     And the JSON node "data.updateDummy.name" should be equal to "Dummy #1"
     And the JSON node "data.updateDummy.description" should be equal to "Modified description."
 
-  @dropSchema
   # @TODO Find a way to manage composite identifiers.
   Scenario: Modify an item with composite identifiers through a mutation
     Given there are Composite identifier objects
@@ -115,3 +114,24 @@ Feature: GraphQL mutation support
     #And the JSON node "data.putCompositeRelation.compositeItem.id" should be equal to 1
     #And the JSON node "data.putCompositeRelation.compositeLabel.id" should be equal to 1
     #And the JSON node "data.putCompositeRelation.value" should be equal to "Modified value."
+
+  @dropSchema
+  Scenario: Create an item
+    When I send the following GraphQL request:
+    """
+    mutation {
+      createDummy(input: {name: "A new one", alias: "new", description: "brand new!"}) {
+        id,
+        name,
+        alias,
+        description
+      }
+    }
+    """
+    Then the response status code should be 200
+    And the response should be in JSON
+    And the header "Content-Type" should be equal to "application/json"
+    And the JSON node "data.createDummy.id" should be equal to 2
+    And the JSON node "data.createDummy.name" should be equal to "A new one"
+    And the JSON node "data.createDummy.alias" should be equal to "new"
+    And the JSON node "data.createDummy.description" should be equal to "brand new!"

src/Bridge/Graphql/Resolver/ItemMutationResolverFactory.php

@@ -48,10 +48,9 @@ public function __construct(IdentifiersExtractorInterface $identifiersExtractor,
     public function createItemMutationResolver(string $resourceClass, string $mutationName): callable
     {
         return function ($root, $args, $context, ResolveInfo $info) use ($resourceClass, $mutationName) {
-            $id = $this->getIdentifier($this->identifiersExtractor->getIdentifiersFromResourceClass($resourceClass), $args, $info);
             $item = null;
-
             if ('update' === $mutationName || 'delete' === $mutationName) {
+                $id = $this->getIdentifier($this->identifiersExtractor->getIdentifiersFromResourceClass($resourceClass), $args, $info);
                 $item = $this->getItem($resourceClass, $id, $info);
             }
 

src/Bridge/Graphql/Type/SchemaBuilder.php

@@ -287,9 +287,13 @@ private function getResourceObjectTypeFields(string $resource, bool $isInput = f
         $fields = [];
         foreach ($this->propertyNameCollectionFactory->create($resource) as $property) {
             $propertyMetadata = $this->propertyMetadataFactory->create($resource, $property);
-            if (null === ($propertyType = $propertyMetadata->getType())
-                || !$propertyMetadata->isReadable()
-                || ($isMutation && 'delete' === $mutationName && !$propertyMetadata->isIdentifier())) {
+            if (
+                null === ($propertyType = $propertyMetadata->getType())
+                || (!$isInput && !$isMutation && !$propertyMetadata->isReadable())
+                //|| ($isMutation && !$propertyMetadata->isWritable())
+                || ($isInput && $isMutation && 'create' === $mutationName && $propertyMetadata->isIdentifier())
+                || ($isMutation && 'delete' === $mutationName && !$propertyMetadata->isIdentifier())
+            ) {
                 continue;
             }
 

src/Metadata/Resource/Factory/OperationResourceMetadataFactory.php

@@ -84,7 +84,7 @@ public function create(string $resourceClass): ResourceMetadata
 
         $graphql = $resourceMetadata->getGraphql();
         if (null === $graphql) {
-            $resourceMetadata = $resourceMetadata->withGraphql(['query' => [], 'delete' => [], 'update' => []]);
+            $resourceMetadata = $resourceMetadata->withGraphql(['query' => [], 'delete' => [], 'update' => [], 'create' => []]);
         } else {
             $resourceMetadata = $this->normalizeGraphQl($resourceMetadata, $graphql);
         }