Disable Messenger From Config

- Added ability to disable messenger from config
- Removed previous check if container has message_bus

Signed-off-by: RJ Garcia <[email protected]>

Author: ragboyjr

src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php

@@ -41,7 +41,6 @@
 use Symfony\Component\ExpressionLanguage\ExpressionLanguage;
 use Symfony\Component\Finder\Finder;
 use Symfony\Component\HttpKernel\DependencyInjection\Extension;
-use Symfony\Component\Messenger\MessageBusInterface;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
 use Symfony\Component\Yaml\Yaml;
 
@@ -149,11 +148,8 @@ public function load(array $configs, ContainerBuilder $container)
         $this->registerValidatorConfiguration($container, $config);
         $this->registerDataCollectorConfiguration($container, $config, $loader);
         $this->registerMercureConfiguration($container, $config, $loader, $useDoctrine);
+        $this->registerMessengerConfiguration($config, $loader);
         $this->registerElasticsearchConfiguration($container, $config, $loader);
-
-        if (interface_exists(MessageBusInterface::class) && $container->has('message_bus')) {
-            $loader->load('messenger.xml');
-        }
     }
 
     /**
@@ -580,6 +576,15 @@ private function registerMercureConfiguration(ContainerBuilder $container, array
         }
     }
 
+    private function registerMessengerConfiguration(array $config, XmlFileLoader $loader)
+    {
+        if (!$config['messenger']['enabled']) {
+            return;
+        }
+
+        $loader->load('messenger.xml');
+    }
+
     private function registerElasticsearchConfiguration(ContainerBuilder $container, array $config, XmlFileLoader $loader)
     {
         $enabled = $config['elasticsearch']['enabled'] && class_exists(Client::class);

src/Bridge/Symfony/Bundle/DependencyInjection/Configuration.php

@@ -28,6 +28,7 @@
 use Symfony\Component\Config\Definition\ConfigurationInterface;
 use Symfony\Component\Config\Definition\Exception\InvalidConfigurationException;
 use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\Messenger\MessageBusInterface;
 use Symfony\Component\Serializer\Exception\ExceptionInterface;
 
 /**
@@ -245,6 +246,10 @@ public function getConfigTreeBuilder()
                     ->end()
                 ->end()
 
+                ->arrayNode('messenger')
+                    ->{interface_exists(MessageBusInterface::class) ? 'canBeDisabled' : 'canBeEnabled'}()
+                ->end()
+
                 ->arrayNode('elasticsearch')
                     ->canBeEnabled()
                     ->addDefaultsIfNotSet()

tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php

@@ -471,6 +471,19 @@ public function testDisabledSwaggerUIAndRedoc()
         $this->extension->load($config, $containerBuilder);
     }
 
+    public function testDisabledMessenger()
+    {
+        $containerBuilderProphecy = $this->getBaseContainerBuilderProphecy();
+        $containerBuilderProphecy->setAlias('api_platform.message_bus', 'message_bus')->shouldNotBeCalled();
+        $containerBuilderProphecy->setDefinition('api_platform.messenger.data_persister', Argument::type(Definition::class))->shouldNotBeCalled();
+        $containerBuilder = $containerBuilderProphecy->reveal();
+
+        $config = self::DEFAULT_CONFIG;
+        $config['api_platform']['messenger']['enabled'] = false;
+
+        $this->extension->load($config, $containerBuilder);
+    }
+
     public function testDisableDoctrine()
     {
         $containerBuilderProphecy = $this->getBaseContainerBuilderProphecy();
@@ -837,7 +850,6 @@ private function getPartialContainerBuilderProphecy()
         $containerBuilderProphecy->getParameter('kernel.debug')->willReturn(false);
 
         $containerBuilderProphecy->getDefinition('api_platform.http_cache.purger.varnish')->willReturn(new Definition());
-        $containerBuilderProphecy->has('message_bus')->willReturn(true);
 
         return $containerBuilderProphecy;
     }

tests/Bridge/Symfony/Bundle/DependencyInjection/ConfigurationTest.php

@@ -157,6 +157,9 @@ public function testDefaultConfig()
             'doctrine_mongodb_odm' => [
                 'enabled' => true,
             ],
+            'messenger' => [
+                'enabled' => true,
+            ],
             'mercure' => [
                 'enabled' => true,
                 'hub_url' => null,