Skip to content

Commit b125b66

Browse files
committed
Merge branch '2.5'
* 2.5: Fix spelling Fix removal of illegal characters in schema name for Amazon API Gateway Add links to documentation to ApiResource properties fix #3189 - JSONAPI pagination ignored when using filter parameter
2 parents 449842a + 79e4b86 commit b125b66

File tree

8 files changed

+588
-210
lines changed

8 files changed

+588
-210
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,7 @@ Please read #2825 if you have issues with the behavior of Readable/Writable Link
424424
* Persist data in Doctrine DataPersister only if needed
425425
* Fix identifiers handling in GraphQL mutations
426426
* Fix client-side ID creation or update when using GraphQL mutations
427-
* Fix an error that was occuring when the Expression Language component wasn't installed
427+
* Fix an error that was occurring when the Expression Language component wasn't installed
428428
* Update the `ChainSubresourceDataProvider` class to take into account `RestrictedDataProviderInterface`
429429
430430
## 2.2.4

features/jsonapi/filtering.feature

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,14 @@ Feature: JSON API filter handling
2323
And the JSON should be valid according to the JSON API schema
2424
And the JSON node "data" should have 0 elements
2525

26+
Scenario: Apply filters and pagination at the same time
27+
When I send a "GET" request to "/dummies?filter[name]=foo&page[page]=2"
28+
Then the response status code should be 200
29+
And the response should be in JSON
30+
And the JSON should be valid according to the JSON API schema
31+
Then the JSON node "meta.currentPage" should be a number
32+
Then the JSON node "meta.currentPage" should be equal to "2"
33+
2634
Scenario: Apply property filter based on the 'fields'
2735
Given there are 2 dummy property objects
2836
When I send a "GET" request to "/dummy_properties?fields[DummyProperty]=id,foo,bar"

features/main/subresource.feature

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Feature: Subresource support
2424
}
2525
"""
2626

27-
Scenario: Get a non existant subresource
27+
Scenario: Get a non existent subresource
2828
Given there is an answer "42" to the question "What's the answer to the Ultimate Question of Life, the Universe and Everything?"
2929
When I send a "GET" request to "/questions/999999/answer"
3030
Then the response status code should be 404

0 commit comments

Comments
 (0)