Skip to content

Commit b9c9fa6

Browse files
committed
fix error when disabling eager_loading.
Introduced by d3b690e
1 parent 15db1f3 commit b9c9fa6

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414
namespace ApiPlatform\Core\Bridge\Symfony\Bundle\DependencyInjection;
1515

1616
use ApiPlatform\Core\Api\FilterInterface;
17+
use ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\EagerLoadingExtension;
18+
use ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\FilterEagerLoadingExtension;
1719
use ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\QueryCollectionExtensionInterface;
1820
use ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\QueryItemExtensionInterface;
1921
use ApiPlatform\Core\DataProvider\CollectionDataProviderInterface;
@@ -412,7 +414,9 @@ private function registerDoctrineExtensionConfiguration(ContainerBuilder $contai
412414
return;
413415
}
414416

417+
$container->removeAlias(EagerLoadingExtension::class);
415418
$container->removeDefinition('api_platform.doctrine.orm.query_extension.eager_loading');
419+
$container->removeAlias(FilterEagerLoadingExtension::class);
416420
$container->removeDefinition('api_platform.doctrine.orm.query_extension.filter_eager_loading');
417421
}
418422

tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -275,6 +275,8 @@ public function testDisableEagerLoadingExtension()
275275
{
276276
$containerBuilderProphecy = $this->getBaseContainerBuilderProphecy();
277277
$containerBuilderProphecy->setParameter('api_platform.eager_loading.enabled', false)->shouldBeCalled();
278+
$containerBuilderProphecy->removeAlias('ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\EagerLoadingExtension')->shouldBeCalled();
279+
$containerBuilderProphecy->removeAlias('ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\FilterEagerLoadingExtension')->shouldBeCalled();
278280
$containerBuilderProphecy->removeDefinition('api_platform.doctrine.orm.query_extension.eager_loading')->shouldBeCalled();
279281
$containerBuilderProphecy->removeDefinition('api_platform.doctrine.orm.query_extension.filter_eager_loading')->shouldBeCalled();
280282
$containerBuilder = $containerBuilderProphecy->reveal();

0 commit comments

Comments
 (0)