Skip to content

Commit babe7bb

Browse files
author
abluchet
committed
fix phpstan errors
1 parent 548f577 commit babe7bb

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

phpstan.neon

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,5 @@ parameters:
1010
- '#Call to an undefined method PHPUnit_Framework_MockObject_MockObject::[a-zA-Z0-9_]+\(\)#'
1111

1212
# False positives
13-
- '#scalar#' # Fixed in PHPStan 0.7
1413
- '#Parameter \#2 \$dqlPart of method Doctrine\\ORM\\QueryBuilder::add\(\) expects Doctrine\\ORM\\Query\\Expr\\Base, Doctrine\\ORM\\Query\\Expr\\Join\[\] given#' # Fixed in Doctrine's master
15-
- '#Parameter \#1 \$rootNode of method ApiPlatform\\Core\\Bridge\\Symfony\\Bundle\\DependencyInjection\\Configuration::[a-zA-Z0-9]+\(\) expects Symfony\\Component\\Config\\Definition\\Builder\\ArrayNodeDefinition, Symfony\\Component\\Config\\Definition\\Builder\\ArrayNodeDefinition|Symfony\\Component\\Config\\Definition\\Builder\\NodeDefinition given#'
16-
- '#Parameter \#1 \$source of static method ApiPlatform\\Core\\Util\\RequestParser::parseRequestParams\(\) expects string, string\|resource given#'
14+
- '#Parameter \#1 \$callable of static method Doctrine\\Common\\Annotations\\AnnotationRegistry::registerLoader\(\) expects callable, mixed\[\] given#'

src/Bridge/Doctrine/Orm/Extension/FilterEagerLoadingExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ final class FilterEagerLoadingExtension implements QueryCollectionExtensionInter
2727
{
2828
use EagerLoadingTrait;
2929

30-
public function __construct(ResourceMetadataFactoryInterface $resourceMetadataFactory, $forceEager = true)
30+
public function __construct(ResourceMetadataFactoryInterface $resourceMetadataFactory, bool $forceEager = true)
3131
{
3232
$this->resourceMetadataFactory = $resourceMetadataFactory;
3333
$this->forceEager = $forceEager;

src/Bridge/Doctrine/Orm/Util/EagerLoadingTrait.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ private function shouldOperationForceEager(string $resourceClass, array $options
4646
$forceEager = $resourceMetadata->getAttribute('force_eager');
4747
}
4848

49-
return is_bool($forceEager) ? $forceEager : $this->forceEager;
49+
return is_bool($forceEager) ? $forceEager : (bool) $this->forceEager;
5050
}
5151

5252
/**

0 commit comments

Comments
 (0)