chore: disable nullable_type_declaration_for_default_null_value CS rule

Author: vincentchalamon

.php-cs-fixer.dist.php

@@ -89,6 +89,11 @@
         'no_unset_on_property' => true,
         'no_useless_else' => true,
         'no_useless_return' => true,
+        'nullable_type_declaration_for_default_null_value' => [
+            // enabled by default on v3.49.0 in SymfonySet
+            // https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/pull/7773
+            'use_nullable_type_declaration' => false, // temporary
+        ],
         'ordered_imports' => [
             'imports_order' => [
                 'class',

src/Api/FilterLocatorTrait.php

@@ -45,7 +45,7 @@ private function setFilterLocator(?ContainerInterface $filterLocator, bool $allo
     /**
      * Gets a filter with a backward compatibility.
      */
-    private function getFilter(string $filterId): null|FilterInterface|MetadataFilterInterface
+    private function getFilter(string $filterId): FilterInterface|MetadataFilterInterface|null
     {
         if ($this->filterLocator && $this->filterLocator->has($filterId)) {
             return $this->filterLocator->get($filterId);

src/Doctrine/Common/Filter/SearchFilterTrait.php

@@ -34,7 +34,7 @@ trait SearchFilterTrait
 
     protected IriConverterInterface|LegacyIriConverterInterface $iriConverter;
     protected PropertyAccessorInterface $propertyAccessor;
-    protected null|IdentifiersExtractorInterface|LegacyIdentifiersExtractorInterface $identifiersExtractor = null;
+    protected IdentifiersExtractorInterface|LegacyIdentifiersExtractorInterface|null $identifiersExtractor = null;
 
     /**
      * {@inheritdoc}

src/Doctrine/Odm/Filter/SearchFilter.php

@@ -142,7 +142,7 @@ final class SearchFilter extends AbstractFilter implements SearchFilterInterface
 
     public const DOCTRINE_INTEGER_TYPE = [MongoDbType::INTEGER, MongoDbType::INT];
 
-    public function __construct(ManagerRegistry $managerRegistry, IriConverterInterface|LegacyIriConverterInterface $iriConverter, null|IdentifiersExtractorInterface|LegacyIdentifiersExtractorInterface $identifiersExtractor, PropertyAccessorInterface $propertyAccessor = null, LoggerInterface $logger = null, array $properties = null, NameConverterInterface $nameConverter = null)
+    public function __construct(ManagerRegistry $managerRegistry, IriConverterInterface|LegacyIriConverterInterface $iriConverter, IdentifiersExtractorInterface|LegacyIdentifiersExtractorInterface|null $identifiersExtractor, PropertyAccessorInterface $propertyAccessor = null, LoggerInterface $logger = null, array $properties = null, NameConverterInterface $nameConverter = null)
     {
         parent::__construct($managerRegistry, $logger, $properties, $nameConverter);
 

src/ParameterValidator/FilterLocatorTrait.php

@@ -45,7 +45,7 @@ private function setFilterLocator(?ContainerInterface $filterLocator, bool $allo
     /**
      * Gets a filter with a backward compatibility.
      */
-    private function getFilter(string $filterId): null|FilterInterface
+    private function getFilter(string $filterId): FilterInterface|null
     {
         if ($this->filterLocator && $this->filterLocator->has($filterId)) {
             return $this->filterLocator->get($filterId);

src/State/UriVariablesResolverTrait.php

@@ -21,7 +21,7 @@
 
 trait UriVariablesResolverTrait
 {
-    private null|LegacyUriVariablesConverterInterface|UriVariablesConverterInterface $uriVariablesConverter = null;
+    private LegacyUriVariablesConverterInterface|UriVariablesConverterInterface|null $uriVariablesConverter = null;
 
     /**
      * Resolves an operation's UriVariables to their identifiers values.

src/Symfony/EventListener/DeserializeListener.php

@@ -48,7 +48,7 @@ final class DeserializeListener
     private SerializerInterface $serializer;
     private ?ProviderInterface $provider = null;
 
-    public function __construct(ProviderInterface|SerializerInterface $serializer, private readonly null|SerializerContextBuilderInterface|ResourceMetadataCollectionFactoryInterface $serializerContextBuilder = null, ResourceMetadataCollectionFactoryInterface $resourceMetadataFactory = null, private ?TranslatorInterface $translator = null)
+    public function __construct(ProviderInterface|SerializerInterface $serializer, private readonly SerializerContextBuilderInterface|ResourceMetadataCollectionFactoryInterface|null $serializerContextBuilder = null, ResourceMetadataCollectionFactoryInterface $resourceMetadataFactory = null, private ?TranslatorInterface $translator = null)
     {
         if ($serializer instanceof ProviderInterface) {
             $this->provider = $serializer;

src/Symfony/EventListener/ErrorListener.php

@@ -57,8 +57,8 @@ public function __construct(
         private readonly array $errorFormats = [],
         private readonly array $exceptionToStatus = [],
         /** @phpstan-ignore-next-line we're not using this anymore but keeping for bc layer */
-        private readonly null|IdentifiersExtractorInterface|LegacyIdentifiersExtractorInterface $identifiersExtractor = null,
-        private readonly null|ResourceClassResolverInterface|LegacyResourceClassResolverInterface $resourceClassResolver = null,
+        private readonly IdentifiersExtractorInterface|LegacyIdentifiersExtractorInterface|null $identifiersExtractor = null,
+        private readonly ResourceClassResolverInterface|LegacyResourceClassResolverInterface|null $resourceClassResolver = null,
         Negotiator $negotiator = null,
         private readonly bool $problemCompliantErrors = true,
     ) {

src/Symfony/EventListener/RespondListener.php

@@ -39,7 +39,7 @@ final class RespondListener
         'DELETE' => Response::HTTP_NO_CONTENT,
     ];
 
-    private null|IriConverterInterface|LegacyIriConverterInterface $iriConverter = null;
+    private IriConverterInterface|LegacyIriConverterInterface|null $iriConverter = null;
     private ?ProcessorInterface $processor = null;
 
     public function __construct(ResourceMetadataCollectionFactoryInterface $resourceMetadataFactory = null, IriConverterInterface|LegacyIriConverterInterface|ProcessorInterface $iriConverter = null)

src/Symfony/EventListener/WriteListener.php

@@ -57,7 +57,7 @@ final class WriteListener
     public function __construct(
         private readonly ProcessorInterface $processor,
         LegacyIriConverterInterface|IriConverterInterface|ResourceMetadataCollectionFactoryInterface $iriConverter = null,
-        private readonly null|ResourceClassResolverInterface|LegacyResourceClassResolverInterface $resourceClassResolver = null,
+        private readonly ResourceClassResolverInterface|LegacyResourceClassResolverInterface|null $resourceClassResolver = null,
         ResourceMetadataCollectionFactoryInterface $resourceMetadataCollectionFactory = null,
         LegacyUriVariablesConverterInterface|UriVariablesConverterInterface $uriVariablesConverter = null,
     ) {

tests/Fixtures/app/console

@@ -10,6 +10,8 @@
  * file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
 use Symfony\Bundle\FrameworkBundle\Console\Application;
 use Symfony\Component\Console\Input\ArgvInput;
 use Symfony\Component\ErrorHandler\Debug;