Merge pull request #1387 from soyuka/fix/cache-denormalization

dunglas · web-flow · commit c3c380e4ec3e · 2017-09-21T11:35:13.000+02:00
In memory cache for supportsDenormalization types
diff --git a/src/Serializer/AbstractItemNormalizer.php b/src/Serializer/AbstractItemNormalizer.php
@@ -43,6 +43,7 @@ abstract class AbstractItemNormalizer extends AbstractObjectNormalizer
     protected $iriConverter;
     protected $resourceClassResolver;
     protected $propertyAccessor;
+    protected $localCache = [];
 
     public function __construct(PropertyNameCollectionFactoryInterface $propertyNameCollectionFactory, PropertyMetadataFactoryInterface $propertyMetadataFactory, IriConverterInterface $iriConverter, ResourceClassResolverInterface $resourceClassResolver, PropertyAccessorInterface $propertyAccessor = null, NameConverterInterface $nameConverter = null, ClassMetadataFactoryInterface $classMetadataFactory = null)
     {
@@ -99,7 +100,7 @@ public function normalize($object, $format = null, array $context = [])
      */
     public function supportsDenormalization($data, $type, $format = null)
     {
-        return $this->resourceClassResolver->isResourceClass($type);
+        return $this->localCache[$type] ?? $this->localCache[$type] = $this->resourceClassResolver->isResourceClass($type);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,7 @@ abstract class AbstractItemNormalizer extends AbstractObjectNormalizer`
`43`	`43`	`protected $iriConverter;`
`44`	`44`	`protected $resourceClassResolver;`
`45`	`45`	`protected $propertyAccessor;`
	`46`	`+ protected $localCache = [];`
`46`	`47`
`47`	`48`	`public function __construct(PropertyNameCollectionFactoryInterface $propertyNameCollectionFactory, PropertyMetadataFactoryInterface $propertyMetadataFactory, IriConverterInterface $iriConverter, ResourceClassResolverInterface $resourceClassResolver, PropertyAccessorInterface $propertyAccessor = null, NameConverterInterface $nameConverter = null, ClassMetadataFactoryInterface $classMetadataFactory = null)`
`48`	`49`	`{`
`@@ -99,7 +100,7 @@ public function normalize($object, $format = null, array $context = [])`
`99`	`100`	`*/`
`100`	`101`	`public function supportsDenormalization($data, $type, $format = null)`
`101`	`102`	`{`
`102`		`- return $this->resourceClassResolver->isResourceClass($type);`
	`103`	`+ return $this->localCache[$type] ?? $this->localCache[$type] = $this->resourceClassResolver->isResourceClass($type);`
`103`	`104`	`}`
`104`	`105`
`105`	`106`	`/**`