Skip to content

Commit d3e9f29

Browse files
dunglasdunglas
committed
Fix unit tests
1 parent 8152f8e commit d3e9f29

File tree

4 files changed

+0
-121
lines changed

4 files changed

+0
-121
lines changed

‎src/EventListener/DeserializeListener.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
use ApiPlatform\Core\Api\FormatMatcher;
1717
use ApiPlatform\Core\Api\FormatsProviderInterface;
1818
use ApiPlatform\Core\Exception\InvalidArgumentException;
19-
use ApiPlatform\Core\Metadata\Resource\Factory\ResourceMetadataFactoryInterface;
2019
use ApiPlatform\Core\Serializer\SerializerContextBuilderInterface;
2120
use ApiPlatform\Core\Util\RequestAttributesExtractor;
2221
use Symfony\Component\HttpFoundation\Request;

‎tests/Operation/Factory/SubresourceOperationFactoryTest.php

Lines changed: 0 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,6 @@ public function testCreate()
6666
'property' => 'subresource',
6767
'collection' => false,
6868
'resource_class' => RelatedDummyEntity::class,
69-
'input_class' => RelatedDummyEntity::class,
70-
'output_class' => RelatedDummyEntity::class,
7169
'shortNames' => ['relatedDummyEntity', 'dummyEntity'],
7270
'identifiers' => [
7371
['id', DummyEntity::class, true],
@@ -80,8 +78,6 @@ public function testCreate()
8078
'property' => 'anotherSubresource',
8179
'collection' => false,
8280
'resource_class' => DummyEntity::class,
83-
'input_class' => DummyEntity::class,
84-
'output_class' => DummyEntity::class,
8581
'shortNames' => ['dummyEntity', 'relatedDummyEntity'],
8682
'identifiers' => [
8783
['id', DummyEntity::class, true],
@@ -95,8 +91,6 @@ public function testCreate()
9591
'property' => 'subcollection',
9692
'collection' => true,
9793
'resource_class' => RelatedDummyEntity::class,
98-
'input_class' => RelatedDummyEntity::class,
99-
'output_class' => RelatedDummyEntity::class,
10094
'shortNames' => ['relatedDummyEntity', 'dummyEntity'],
10195
'identifiers' => [
10296
['id', DummyEntity::class, true],
@@ -111,8 +105,6 @@ public function testCreate()
111105
'property' => 'subcollection',
112106
'collection' => true,
113107
'resource_class' => RelatedDummyEntity::class,
114-
'input_class' => RelatedDummyEntity::class,
115-
'output_class' => RelatedDummyEntity::class,
116108
'shortNames' => ['relatedDummyEntity', 'dummyEntity'],
117109
'identifiers' => [
118110
['id', DummyEntity::class, true],
@@ -125,8 +117,6 @@ public function testCreate()
125117
'property' => 'anotherSubresource',
126118
'collection' => false,
127119
'resource_class' => DummyEntity::class,
128-
'input_class' => DummyEntity::class,
129-
'output_class' => DummyEntity::class,
130120
'shortNames' => ['dummyEntity', 'relatedDummyEntity'],
131121
'identifiers' => [
132122
['id', DummyEntity::class, true],
@@ -140,8 +130,6 @@ public function testCreate()
140130
'property' => 'subresource',
141131
'collection' => false,
142132
'resource_class' => RelatedDummyEntity::class,
143-
'input_class' => RelatedDummyEntity::class,
144-
'output_class' => RelatedDummyEntity::class,
145133
'shortNames' => ['relatedDummyEntity', 'dummyEntity'],
146134
'identifiers' => [
147135
['id', DummyEntity::class, true],
@@ -196,8 +184,6 @@ public function testCreateByOverriding()
196184
'property' => 'subresource',
197185
'collection' => false,
198186
'resource_class' => RelatedDummyEntity::class,
199-
'input_class' => RelatedDummyEntity::class,
200-
'output_class' => RelatedDummyEntity::class,
201187
'shortNames' => ['relatedDummyEntity', 'dummyEntity'],
202188
'identifiers' => [
203189
['id', DummyEntity::class, true],
@@ -210,8 +196,6 @@ public function testCreateByOverriding()
210196
'property' => 'anotherSubresource',
211197
'collection' => false,
212198
'resource_class' => DummyEntity::class,
213-
'input_class' => DummyEntity::class,
214-
'output_class' => DummyEntity::class,
215199
'shortNames' => ['dummyEntity', 'relatedDummyEntity'],
216200
'identifiers' => [
217201
['id', DummyEntity::class, true],
@@ -225,8 +209,6 @@ public function testCreateByOverriding()
225209
'property' => 'subcollection',
226210
'collection' => true,
227211
'resource_class' => RelatedDummyEntity::class,
228-
'input_class' => RelatedDummyEntity::class,
229-
'output_class' => RelatedDummyEntity::class,
230212
'shortNames' => ['relatedDummyEntity', 'dummyEntity'],
231213
'identifiers' => [
232214
['id', DummyEntity::class, true],
@@ -241,8 +223,6 @@ public function testCreateByOverriding()
241223
'property' => 'subcollection',
242224
'collection' => true,
243225
'resource_class' => RelatedDummyEntity::class,
244-
'input_class' => RelatedDummyEntity::class,
245-
'output_class' => RelatedDummyEntity::class,
246226
'shortNames' => ['relatedDummyEntity', 'dummyEntity'],
247227
'identifiers' => [
248228
['id', DummyEntity::class, true],
@@ -255,8 +235,6 @@ public function testCreateByOverriding()
255235
'property' => 'anotherSubresource',
256236
'collection' => false,
257237
'resource_class' => DummyEntity::class,
258-
'input_class' => DummyEntity::class,
259-
'output_class' => DummyEntity::class,
260238
'shortNames' => ['dummyEntity', 'relatedDummyEntity'],
261239
'identifiers' => [
262240
['id', DummyEntity::class, true],
@@ -270,8 +248,6 @@ public function testCreateByOverriding()
270248
'property' => 'subresource',
271249
'collection' => false,
272250
'resource_class' => RelatedDummyEntity::class,
273-
'input_class' => RelatedDummyEntity::class,
274-
'output_class' => RelatedDummyEntity::class,
275251
'shortNames' => ['relatedDummyEntity', 'dummyEntity'],
276252
'identifiers' => [
277253
['id', DummyEntity::class, true],
@@ -319,8 +295,6 @@ public function testCreateWithMaxDepth()
319295
'property' => 'subresource',
320296
'collection' => false,
321297
'resource_class' => RelatedDummyEntity::class,
322-
'input_class' => RelatedDummyEntity::class,
323-
'output_class' => RelatedDummyEntity::class,
324298
'shortNames' => ['relatedDummyEntity', 'dummyEntity'],
325299
'identifiers' => [
326300
['id', DummyEntity::class, true],
@@ -381,8 +355,6 @@ public function testCreateWithMaxDepthMultipleSubresources()
381355
'property' => 'subresource',
382356
'collection' => false,
383357
'resource_class' => RelatedDummyEntity::class,
384-
'input_class' => RelatedDummyEntity::class,
385-
'output_class' => RelatedDummyEntity::class,
386358
'shortNames' => ['relatedDummyEntity', 'dummyEntity'],
387359
'identifiers' => [
388360
['id', DummyEntity::class, true],
@@ -395,8 +367,6 @@ public function testCreateWithMaxDepthMultipleSubresources()
395367
'property' => 'secondSubresource',
396368
'collection' => false,
397369
'resource_class' => DummyValidatedEntity::class,
398-
'input_class' => DummyValidatedEntity::class,
399-
'output_class' => DummyValidatedEntity::class,
400370
'shortNames' => ['dummyValidatedEntity', 'dummyEntity'],
401371
'identifiers' => [
402372
['id', DummyEntity::class, true],
@@ -409,8 +379,6 @@ public function testCreateWithMaxDepthMultipleSubresources()
409379
'property' => 'moreSubresource',
410380
'collection' => false,
411381
'resource_class' => RelatedDummyEntity::class,
412-
'input_class' => RelatedDummyEntity::class,
413-
'output_class' => RelatedDummyEntity::class,
414382
'shortNames' => ['relatedDummyEntity', 'dummyValidatedEntity'],
415383
'identifiers' => [
416384
['id', DummyEntity::class, true],
@@ -471,8 +439,6 @@ public function testCreateWithMaxDepthMultipleSubresourcesSameMaxDepth()
471439
'property' => 'subresource',
472440
'collection' => false,
473441
'resource_class' => RelatedDummyEntity::class,
474-
'input_class' => RelatedDummyEntity::class,
475-
'output_class' => RelatedDummyEntity::class,
476442
'shortNames' => ['relatedDummyEntity', 'dummyEntity'],
477443
'identifiers' => [
478444
['id', DummyEntity::class, true],
@@ -485,8 +451,6 @@ public function testCreateWithMaxDepthMultipleSubresourcesSameMaxDepth()
485451
'property' => 'secondSubresource',
486452
'collection' => false,
487453
'resource_class' => DummyValidatedEntity::class,
488-
'input_class' => DummyValidatedEntity::class,
489-
'output_class' => DummyValidatedEntity::class,
490454
'shortNames' => ['dummyValidatedEntity', 'dummyEntity'],
491455
'identifiers' => [
492456
['id', DummyEntity::class, true],
@@ -530,8 +494,6 @@ public function testCreateSelfReferencingSubresources()
530494
'property' => 'subresource',
531495
'collection' => false,
532496
'resource_class' => DummyEntity::class,
533-
'input_class' => DummyEntity::class,
534-
'output_class' => DummyEntity::class,
535497
'shortNames' => ['dummyEntity'],
536498
'identifiers' => [
537499
['id', DummyEntity::class, true],
@@ -577,8 +539,6 @@ public function testCreateWithEnd()
577539
'property' => 'subresource',
578540
'collection' => true,
579541
'resource_class' => RelatedDummyEntity::class,
580-
'input_class' => RelatedDummyEntity::class,
581-
'output_class' => RelatedDummyEntity::class,
582542
'shortNames' => ['relatedDummyEntity', 'dummyEntity'],
583543
'identifiers' => [
584544
['id', DummyEntity::class, true],
@@ -591,8 +551,6 @@ public function testCreateWithEnd()
591551
'property' => 'id',
592552
'collection' => false,
593553
'resource_class' => DummyEntity::class,
594-
'input_class' => DummyEntity::class,
595-
'output_class' => DummyEntity::class,
596554
'shortNames' => ['dummyEntity', 'relatedDummyEntity'],
597555
'identifiers' => [
598556
['id', DummyEntity::class, true],
@@ -639,8 +597,6 @@ public function testCreateWithEndButNoCollection()
639597
'property' => 'subresource',
640598
'collection' => false,
641599
'resource_class' => RelatedDummyEntity::class,
642-
'input_class' => RelatedDummyEntity::class,
643-
'output_class' => RelatedDummyEntity::class,
644600
'shortNames' => ['relatedDummyEntity', 'dummyEntity'],
645601
'identifiers' => [
646602
['id', DummyEntity::class, true],
@@ -690,8 +646,6 @@ public function testCreateWithRootResourcePrefix()
690646
'identifiers' => [
691647
['id', DummyEntity::class, true],
692648
],
693-
'input_class' => RelatedDummyEntity::class,
694-
'output_class' => RelatedDummyEntity::class,
695649
'route_name' => 'api_dummy_entities_subresource_get_subresource',
696650
'path' => '/root_resource_prefix/dummy_entities/{id}/subresource.{_format}',
697651
'operation_name' => 'subresource_get_subresource',

‎tests/Serializer/SerializerFilterContextBuilderTest.php

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,6 @@ public function testCreateFromRequestWithCollectionOperation()
3636

3737
$attributes = [
3838
'resource_class' => DummyGroup::class,
39-
'input_class' => DummyGroup::class,
40-
'output_class' => DummyGroup::class,
4139
'collection_operation_name' => 'get',
4240
];
4341

@@ -79,8 +77,6 @@ public function testCreateFromRequestWithItemOperation()
7977

8078
$attributes = [
8179
'resource_class' => DummyGroup::class,
82-
'input_class' => DummyGroup::class,
83-
'output_class' => DummyGroup::class,
8480
'item_operation_name' => 'put',
8581
];
8682

@@ -122,8 +118,6 @@ public function testCreateFromRequestWithoutFilters()
122118

123119
$attributes = [
124120
'resource_class' => DummyGroup::class,
125-
'input_class' => DummyGroup::class,
126-
'output_class' => DummyGroup::class,
127121
'collection_operation_name' => 'get',
128122
];
129123

@@ -158,8 +152,6 @@ public function testCreateFromRequestWithoutAttributes()
158152

159153
$attributes = [
160154
'resource_class' => DummyGroup::class,
161-
'input_class' => DummyGroup::class,
162-
'output_class' => DummyGroup::class,
163155
'collection_operation_name' => 'get',
164156
'receive' => true,
165157
'persist' => true,

‎tests/Util/RequestAttributesExtractorTest.php

Lines changed: 0 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@ public function testExtractCollectionAttributes()
3030
[
3131
'resource_class' => 'Foo',
3232
'collection_operation_name' => 'post',
33-
'input_class' => 'Foo',
34-
'output_class' => 'Foo',
3533
'receive' => true,
3634
'persist' => true,
3735
],
@@ -47,8 +45,6 @@ public function testExtractItemAttributes()
4745
[
4846
'resource_class' => 'Foo',
4947
'item_operation_name' => 'get',
50-
'input_class' => 'Foo',
51-
'output_class' => 'Foo',
5248
'receive' => true,
5349
'persist' => true,
5450
],
@@ -64,8 +60,6 @@ public function testExtractReceive()
6460
[
6561
'resource_class' => 'Foo',
6662
'item_operation_name' => 'get',
67-
'input_class' => 'Foo',
68-
'output_class' => 'Foo',
6963
'receive' => false,
7064
'persist' => true,
7165
],
@@ -78,8 +72,6 @@ public function testExtractReceive()
7872
[
7973
'resource_class' => 'Foo',
8074
'item_operation_name' => 'get',
81-
'input_class' => 'Foo',
82-
'output_class' => 'Foo',
8375
'receive' => true,
8476
'persist' => true,
8577
],
@@ -91,8 +83,6 @@ public function testExtractReceive()
9183
$this->assertEquals(
9284
[
9385
'resource_class' => 'Foo',
94-
'input_class' => 'Foo',
95-
'output_class' => 'Foo',
9686
'item_operation_name' => 'get',
9787
'receive' => true,
9888
'persist' => true,
@@ -108,8 +98,6 @@ public function testExtractPersist()
10898
$this->assertEquals(
10999
[
110100
'resource_class' => 'Foo',
111-
'input_class' => 'Foo',
112-
'output_class' => 'Foo',
113101
'item_operation_name' => 'get',
114102
'receive' => true,
115103
'persist' => false,
@@ -122,8 +110,6 @@ public function testExtractPersist()
122110
$this->assertEquals(
123111
[
124112
'resource_class' => 'Foo',
125-
'input_class' => 'Foo',
126-
'output_class' => 'Foo',
127113
'item_operation_name' => 'get',
128114
'receive' => true,
129115
'persist' => true,
@@ -136,8 +122,6 @@ public function testExtractPersist()
136122
$this->assertEquals(
137123
[
138124
'resource_class' => 'Foo',
139-
'input_class' => 'Foo',
140-
'output_class' => 'Foo',
141125
'item_operation_name' => 'get',
142126
'receive' => true,
143127
'persist' => true,
@@ -146,56 +130,6 @@ public function testExtractPersist()
146130
);
147131
}
148132

149-
public function testExtractInputOutputResourceClass()
150-
{
151-
$request = new Request([], [], ['_api_resource_class' => 'Foo', '_api_item_operation_name' => 'get', '_api_input_class' => 'Bar']);
152-
153-
$this->assertEquals(
154-
[
155-
'resource_class' => 'Foo',
156-
'item_operation_name' => 'get',
157-
'input_class' => 'Bar',
158-
'output_class' => 'Foo',
159-
'receive' => true,
160-
'persist' => true,
161-
],
162-
RequestAttributesExtractor::extractAttributes($request)
163-
);
164-
165-
$request = new Request([], [], ['_api_resource_class' => 'Foo', '_api_item_operation_name' => 'get', '_api_output_class' => 'Bar']);
166-
167-
$this->assertEquals(
168-
[
169-
'resource_class' => 'Foo',
170-
'item_operation_name' => 'get',
171-
'input_class' => 'Foo',
172-
'output_class' => 'Bar',
173-
'receive' => true,
174-
'persist' => true,
175-
],
176-
RequestAttributesExtractor::extractAttributes($request)
177-
);
178-
179-
$request = new Request([], [], [
180-
'_api_resource_class' => 'Foo',
181-
'_api_item_operation_name' => 'get',
182-
'_api_input_class' => 'FooBar',
183-
'_api_output_class' => 'Bar',
184-
]);
185-
186-
$this->assertEquals(
187-
[
188-
'resource_class' => 'Foo',
189-
'item_operation_name' => 'get',
190-
'input_class' => 'FooBar',
191-
'output_class' => 'Bar',
192-
'receive' => true,
193-
'persist' => true,
194-
],
195-
RequestAttributesExtractor::extractAttributes($request)
196-
);
197-
}
198-
199133
public function testResourceClassNotSet()
200134
{
201135
$this->assertEmpty(RequestAttributesExtractor::extractAttributes(new Request([], [], ['_api_item_operation_name' => 'get'])));

0 commit comments

Comments
 (0)