Merge pull request #1446 from meyerbaptiste/merge_2.0

Merge branch '2.0'

Author: meyerbaptiste

.php_cs.dist

@@ -43,7 +43,6 @@ return PhpCsFixer\Config::create()
             'throw',
             'use',
         ],
-        'no_unreachable_default_argument_value' => true,
         'no_useless_else' => true,
         'no_useless_return' => true,
         'ordered_imports' => true,

.travis.yml

@@ -15,10 +15,11 @@ matrix:
   include:
     - php: '7.0'
     - php: '7.1'
+    - php: '7.2'
       env: coverage=1 lint=1
-    - php: '7.1'
+    - php: '7.2'
       env: deps='low'
-    - php: '7.1'
+    - php: '7.2'
       env: SYMFONY_DEPRECATIONS_HELPER=0
   allow_failures:
       env: SYMFONY_DEPRECATIONS_HELPER=0
@@ -31,11 +32,11 @@ before_install:
   - if [[ $coverage = 1 ]]; then mkdir -p build/logs build/cov; fi
   - if [[ $coverage = 1 ]]; then wget https://phar.phpunit.de/phpcov.phar; fi
   - if [[ $coverage = 1 ]]; then wget https://github.com/satooshi/php-coveralls/releases/download/v1.0.1/coveralls.phar; fi
-  - if [[ $lint = 1 ]]; then wget https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/download/v2.4.0/php-cs-fixer.phar; fi
+  - if [[ $lint = 1 ]]; then wget https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/download/v2.7.1/php-cs-fixer.phar; fi
   - if [[ $lint = 1 ]]; then composer global require --dev 'phpstan/phpstan:^0.8'; fi
 
 install:
-  - if [[ $coverage = 1 ]]; then composer require --dev --no-update 'phpunit/php-code-coverage:^4.0.1'; fi
+  - if [[ $coverage = 1 ]]; then composer require --dev --no-update 'phpunit/php-code-coverage:^5.2.2'; fi
   - if [[ ! $deps ]]; then composer update --prefer-dist --no-progress --no-suggest --ansi; fi
   - if [[ $deps = 'low' ]]; then composer update --prefer-dist --no-progress --no-suggest --prefer-stable --prefer-lowest --ansi; fi
 

README.md

@@ -9,8 +9,6 @@ It natively supports popular open formats including [JSON for Linked Data (JSON-
 Build a working and fully-featured CRUD API in minutes. Leverage the awesome features of the tool to develop complex and
 high performance API-first projects. Extend or override everything you want.
 
-[![JSON-LD enabled](http://json-ld.org/images/json-ld-button-88.png)](http://json-ld.org)
-[![Join the chat at https://gitter.im/api-platform/api-platform](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/api-platform/api-platform?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 [![Build Status](https://travis-ci.org/api-platform/core.svg?branch=master)](https://travis-ci.org/api-platform/core)
 [![Build status](https://ci.appveyor.com/api/projects/status/grwuyprts3wdqx5l?svg=true)](https://ci.appveyor.com/project/dunglas/dunglasapibundle)
 [![Coverage Status](https://coveralls.io/repos/github/api-platform/core/badge.svg)](https://coveralls.io/github/api-platform/core)

composer.json

@@ -38,10 +38,10 @@
         "friendsofsymfony/user-bundle": "^2.0",
         "guzzlehttp/guzzle": "^6.0",
         "nelmio/api-doc-bundle": "^2.11.2",
-        "php-mock/php-mock-phpunit": "^1.1",
+        "php-mock/php-mock-phpunit": "^2.0",
         "phpdocumentor/reflection-docblock": "^3.0",
-        "phpdocumentor/type-resolver": "^0.2",
-        "phpunit/phpunit": "^5.6.8",
+        "phpdocumentor/type-resolver": "^0.2.1",
+        "phpunit/phpunit": "^6.1",
         "psr/log": "^1.0",
         "sensio/framework-extra-bundle": "^3.0.11 || ^4.0",
         "symfony/asset": "^3.3 || ^4.0",

features/bootstrap/CoverageContext.php

@@ -24,7 +24,7 @@
  * @author Kévin Dunglas <[email protected]>
  * @copyright Adapted from https://gist.github.com/eliecharra/9c8b3ba57998b50e14a6
  */
-class CoverageContext implements Context
+final class CoverageContext implements Context
 {
     /**
      * @var CodeCoverage

features/bootstrap/FeatureContext.php

@@ -43,34 +43,21 @@
 use Behat\Behat\Context\SnippetAcceptingContext;
 use Behatch\HttpCall\Request;
 use Doctrine\Common\Persistence\ManagerRegistry;
-use Doctrine\Common\Persistence\ObjectManager;
+use Doctrine\ORM\EntityManagerInterface;
 use Doctrine\ORM\Tools\SchemaTool;
 
 /**
  * Defines application features from the specific context.
  */
-class FeatureContext implements Context, SnippetAcceptingContext
+final class FeatureContext implements Context, SnippetAcceptingContext
 {
-    private $doctrine;
-
     /**
-     * @var ObjectManager
+     * @var EntityManagerInterface
      */
     private $manager;
-
-    /**
-     * @var SchemaTool
-     */
+    private $doctrine;
     private $schemaTool;
-
-    /**
-     * @var array
-     */
     private $classes;
-
-    /**
-     * @var Request
-     */
     private $request;
 
     /**
@@ -119,7 +106,7 @@ public function dropDatabase()
     /**
      * @Given there is :nb dummy objects
      */
-    public function thereIsDummyObjects($nb)
+    public function thereIsDummyObjects(int $nb)
     {
         $descriptions = ['Smart dummy.', 'Not so smart dummy.'];
 
@@ -139,7 +126,7 @@ public function thereIsDummyObjects($nb)
     /**
      * @Given there are :nb foo objects with fake names
      */
-    public function thereAreFooObjectsWithFakeNames($nb)
+    public function thereAreFooObjectsWithFakeNames(int $nb)
     {
         $names = ['Hawsepipe', 'Sthenelus', 'Ephesian', 'Separativeness', 'Balbo'];
         $bars = ['Lorem', 'Dolor', 'Dolor', 'Sit', 'Amet'];
@@ -158,7 +145,7 @@ public function thereAreFooObjectsWithFakeNames($nb)
     /**
      * @Given there is :nb dummy group objects
      */
-    public function thereIsDummyGroupObjects($nb)
+    public function thereIsDummyGroupObjects(int $nb)
     {
         for ($i = 1; $i <= $nb; ++$i) {
             $dummyGroup = new DummyGroup();
@@ -176,7 +163,7 @@ public function thereIsDummyGroupObjects($nb)
     /**
      * @Given there is :nb dummy property objects
      */
-    public function thereIsDummyPropertyObjects($nb)
+    public function thereIsDummyPropertyObjects(int $nb)
     {
         for ($i = 1; $i <= $nb; ++$i) {
             $dummyProperty = new DummyProperty();
@@ -198,7 +185,7 @@ public function thereIsDummyPropertyObjects($nb)
     /**
      * @Given there are :nb embedded dummy objects
      */
-    public function thereIsEmbeddedDummyObjects($nb)
+    public function thereIsEmbeddedDummyObjects(int $nb)
     {
         for ($i = 1; $i <= $nb; ++$i) {
             $dummy = new EmbeddedDummy();
@@ -217,7 +204,7 @@ public function thereIsEmbeddedDummyObjects($nb)
     /**
      * @Given there is :nb dummy objects with relatedDummy
      */
-    public function thereIsDummyObjectsWithRelatedDummy($nb)
+    public function thereIsDummyObjectsWithRelatedDummy(int $nb)
     {
         for ($i = 1; $i <= $nb; ++$i) {
             $relatedDummy = new RelatedDummy();
@@ -238,7 +225,7 @@ public function thereIsDummyObjectsWithRelatedDummy($nb)
     /**
      * @Given there is :nb dummy objects with embeddedDummy
      */
-    public function thereIsDummyObjectsWithEmbeddedDummy($nb)
+    public function thereIsDummyObjectsWithEmbeddedDummy(int $nb)
     {
         for ($i = 1; $i <= $nb; ++$i) {
             $embeddableDummy = new EmbeddableDummy();
@@ -257,7 +244,7 @@ public function thereIsDummyObjectsWithEmbeddedDummy($nb)
     /**
      * @Given there is :nb dummy objects having each :nbrelated relatedDummies
      */
-    public function thereIsDummyObjectsWithRelatedDummies($nb, $nbrelated)
+    public function thereIsDummyObjectsWithRelatedDummies(int $nb, int $nbrelated)
     {
         for ($i = 1; $i <= $nb; ++$i) {
             $dummy = new Dummy();
@@ -267,11 +254,12 @@ public function thereIsDummyObjectsWithRelatedDummies($nb, $nbrelated)
             for ($j = 1; $j <= $nbrelated; ++$j) {
                 $relatedDummy = new RelatedDummy();
                 $relatedDummy->setName('RelatedDummy'.$j.$i);
+
                 $this->manager->persist($relatedDummy);
+
                 $dummy->addRelatedDummy($relatedDummy);
             }
 
-            $this->manager->persist($relatedDummy);
             $this->manager->persist($dummy);
         }
 
@@ -281,7 +269,7 @@ public function thereIsDummyObjectsWithRelatedDummies($nb, $nbrelated)
     /**
      * @Given there is :nb dummy objects with dummyDate
      */
-    public function thereIsDummyObjectsWithDummyDate($nb)
+    public function thereIsDummyObjectsWithDummyDate(int $nb)
     {
         $descriptions = ['Smart dummy.', 'Not so smart dummy.'];
 
@@ -307,7 +295,7 @@ public function thereIsDummyObjectsWithDummyDate($nb)
     /**
      * @Given there is :nb dummy objects with dummyDate and dummyBoolean :bool
      */
-    public function thereIsDummyObjectsWithDummyDateAndDummyBoolean($nb, $bool)
+    public function thereIsDummyObjectsWithDummyDateAndDummyBoolean(int $nb, string $bool)
     {
         $descriptions = ['Smart dummy.', 'Not so smart dummy.'];
 
@@ -343,7 +331,7 @@ public function thereIsDummyObjectsWithDummyDateAndDummyBoolean($nb, $bool)
     /**
      * @Given there is :nb dummy objects with dummyDate and relatedDummy
      */
-    public function thereIsDummyObjectsWithDummyDateAndRelatedDummy($nb)
+    public function thereIsDummyObjectsWithDummyDateAndRelatedDummy(int $nb)
     {
         for ($i = 1; $i <= $nb; ++$i) {
             $date = new \DateTime(sprintf('2015-04-%d', $i), new \DateTimeZone('UTC'));
@@ -397,7 +385,7 @@ public function thereIsDummyObjectsWithDummyDateAndEmbeddedDummy($nb)
     /**
      * @Given there is :nb dummy objects with dummyPrice
      */
-    public function thereIsDummyObjectsWithDummyPrice($nb)
+    public function thereIsDummyObjectsWithDummyPrice(int $nb)
     {
         $descriptions = ['Smart dummy.', 'Not so smart dummy.'];
         $prices = ['9.99', '12.99', '15.99', '19.99'];
@@ -418,7 +406,7 @@ public function thereIsDummyObjectsWithDummyPrice($nb)
     /**
      * @Given there is :nb dummy objects with dummyBoolean :bool
      */
-    public function thereIsDummyObjectsWithDummyBoolean($nb, $bool)
+    public function thereIsDummyObjectsWithDummyBoolean(int $nb, string $bool)
     {
         if (in_array($bool, ['true', '1', 1], true)) {
             $bool = true;
@@ -446,7 +434,7 @@ public function thereIsDummyObjectsWithDummyBoolean($nb, $bool)
     /**
      * @Given there is :nb embedded dummy objects with embeddedDummy.dummyBoolean :bool
      */
-    public function thereIsDummyObjectsWithEmbeddedDummyBoolean($nb, $bool)
+    public function thereIsDummyObjectsWithEmbeddedDummyBoolean(int $nb, string $bool)
     {
         if (in_array($bool, ['true', '1', 1], true)) {
             $bool = true;
@@ -473,7 +461,7 @@ public function thereIsDummyObjectsWithEmbeddedDummyBoolean($nb, $bool)
     /**
      * @Given there is :nb embedded dummy objects with relatedDummy.embeddedDummy.dummyBoolean :bool
      */
-    public function thereIsDummyObjectsWithRelationEmbeddedDummyBoolean($nb, $bool)
+    public function thereIsDummyObjectsWithRelationEmbeddedDummyBoolean(int $nb, string $bool)
     {
         if (in_array($bool, ['true', '1', 1], true)) {
             $bool = true;
@@ -593,7 +581,7 @@ public function thereIsAFooEntityWithRelatedBars()
     /**
      * @Given there is a RelatedDummy with :nb friends
      */
-    public function thereIsARelatedDummyWithFriends($nb)
+    public function thereIsARelatedDummyWithFriends(int $nb)
     {
         $relatedDummy = new RelatedDummy();
         $relatedDummy->setName('RelatedDummy with friends');
@@ -622,7 +610,7 @@ public function thereIsARelatedDummyWithFriends($nb)
     }
 
     /**
-     * @Given there is an answer ":answer" to the question ":question"
+     * @Given there is an answer :answer to the question :question
      */
     public function thereIsAnAnswerToTheQuestion(string $a, string $q)
     {
@@ -643,7 +631,7 @@ public function thereIsAnAnswerToTheQuestion(string $a, string $q)
     /**
      * @Given there are :nb nodes in a container :uuid
      */
-    public function thereAreNodesInAContainer($nb, $uuid)
+    public function thereAreNodesInAContainer(int $nb, string $uuid)
     {
         $container = new Container();
         $container->setId($uuid);
@@ -662,10 +650,9 @@ public function thereAreNodesInAContainer($nb, $uuid)
     /**
      * @Then the password :password for user :user should be hashed
      */
-    public function thePasswordForUserShouldBeHashed($password, $user)
+    public function thePasswordForUserShouldBeHashed(string $password, string $user)
     {
-        $repository = $this->doctrine->getRepository(User::class);
-        $user = $repository->find($user);
+        $user = $this->doctrine->getRepository(User::class)->find($user);
 
         if (!password_verify($password, $user->getPassword())) {
             throw new \Exception('User password mismatch');

features/bootstrap/HttpCacheContext.php

@@ -12,12 +12,13 @@
 declare(strict_types=1);
 
 use Behat\Symfony2Extension\Context\KernelAwareContext;
+use PHPUnit\Framework\ExpectationFailedException;
 use Symfony\Component\HttpKernel\KernelInterface;
 
 /**
  * @author Kévin Dunglas <[email protected]>
  */
-class HttpCacheContext implements KernelAwareContext
+final class HttpCacheContext implements KernelAwareContext
 {
     /**
      * @var KernelInterface
@@ -30,7 +31,7 @@ public function setKernel(KernelInterface $kernel)
     }
 
     /**
-     * @Then ":iris" IRIs should be purged
+     * @Then :iris IRIs should be purged
      */
     public function irisShouldBePurged(string $iris)
     {
@@ -40,9 +41,7 @@ public function irisShouldBePurged(string $iris)
         $purger->clear();
 
         if ($iris !== $purgedIris) {
-            throw new \PHPUnit_Framework_ExpectationFailedException(
-                sprintf('IRIs "%s" does not match expected "%s".', $purgedIris, $iris)
-            );
+            throw new ExpectationFailedException(sprintf('IRIs "%s" does not match expected "%s".', $purgedIris, $iris));
         }
     }
 }