Merge pull request #914 from dunglas/exclude_static

Exclude static methods in AnnotationPropertyNameCollectionFactory

Author: dunglas

src/Metadata/Property/Factory/AnnotationPropertyNameCollectionFactory.php

@@ -69,6 +69,10 @@ public function create(string $resourceClass, array $options = []): PropertyName
 
         // Methods
         foreach ($reflectionClass->getMethods(\ReflectionMethod::IS_PUBLIC) as $reflectionMethod) {
+            if ($reflectionMethod->isStatic()) {
+                continue;
+            }
+
             $propertyName = $this->reflection->getProperty($reflectionMethod->name);
             if (!preg_match('/^[A-Z]{2,}/', $propertyName)) {
                 $propertyName = lcfirst($propertyName);

tests/Fixtures/TestBundle/Entity/Dummy.php

@@ -130,6 +130,10 @@ class Dummy
      */
     public $nameConverted;
 
+    public static function staticMethod()
+    {
+    }
+
     public function __construct()
     {
         $this->relatedDummies = new ArrayCollection();

tests/Metadata/Property/Factory/AnnotationPropertyNameCollectionFactoryTest.php

@@ -36,6 +36,7 @@ public function testCreate(ProphecyInterface $decorated = null, array $results)
         $reader->getPropertyAnnotation(Argument::type(\ReflectionProperty::class), ApiProperty::class)->willReturn(null)->shouldBeCalled();
         $reader->getMethodAnnotation(new \ReflectionMethod(Dummy::class, 'getName'), ApiProperty::class)->willReturn(new ApiProperty())->shouldBeCalled();
         $reader->getMethodAnnotation(new \ReflectionMethod(Dummy::class, 'getAlias'), ApiProperty::class)->willReturn(new ApiProperty())->shouldBeCalled();
+        $reader->getMethodAnnotation(new \ReflectionMethod(Dummy::class, 'staticMethod'), ApiProperty::class)->shouldNotBeCalled();
         $reader->getMethodAnnotation(Argument::type(\ReflectionMethod::class), ApiProperty::class)->willReturn(null)->shouldBeCalled();
 
         $factory = new AnnotationPropertyNameCollectionFactory($reader->reveal(), $decorated ? $decorated->reveal() : null);