Fix date filter (#1718)

* Fix date filter

* Fix review for @dunglas

* Adds tests for dateFilter

Author: toofff

src/Bridge/Doctrine/Orm/Filter/DateFilter.php

@@ -167,7 +167,7 @@ protected function filterProperty(string $property, $values, QueryBuilder $query
     protected function addWhere(QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $alias, string $field, string $operator, string $value, string $nullManagement = null, $type = null)
     {
         try {
-            $value = false !== strpos('_immutable', $type) ? new \DateTime($value) : new \DateTimeImmutable($value);
+            $value = false === strpos($type, '_immutable') ? new \DateTime($value) : new \DateTimeImmutable($value);
         } catch (\Exception $e) {
             // Silently ignore this filter if it can not be transformed to a \DateTime
             $this->logger->notice('Invalid filter ignored', [

tests/Bridge/Doctrine/Orm/Filter/DateFilterTest.php

@@ -17,6 +17,7 @@
 use ApiPlatform\Core\Bridge\Doctrine\Orm\Util\QueryNameGenerator;
 use ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity\Dummy;
 use ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity\DummyDate;
+use ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity\DummyImmutableDate;
 use Doctrine\Common\Persistence\ManagerRegistry;
 use Doctrine\ORM\EntityRepository;
 use Symfony\Bridge\Doctrine\Test\DoctrineTestHelper;
@@ -103,6 +104,31 @@ public function testApplyDate()
 
         $filter->apply($queryBuilder, new QueryNameGenerator(), DummyDate::class);
         $this->assertEquals(new \DateTime('2015-04-05'), $queryBuilder->getParameters()[0]->getValue());
+        $this->assertInstanceOf(\DateTime::class, $queryBuilder->getParameters()[0]->getValue());
+    }
+
+    public function testApplyDateImmutable()
+    {
+        $request = Request::create('/api/dummy_immutable_dates', 'GET', [
+            'dummyDate' => [
+                'after' => '2015-04-05',
+            ],
+        ]);
+        $requestStack = new RequestStack();
+        $requestStack->push($request);
+
+        $queryBuilder = $this->repository->createQueryBuilder('o');
+
+        $filter = new DateFilter(
+            $this->managerRegistry,
+            $requestStack,
+            null,
+            ['dummyDate' => null]
+        );
+
+        $filter->apply($queryBuilder, new QueryNameGenerator(), DummyImmutableDate::class);
+        $this->assertEquals(new \DateTimeImmutable('2015-04-05'), $queryBuilder->getParameters()[0]->getValue());
+        $this->assertInstanceOf(\DateTimeImmutable::class, $queryBuilder->getParameters()[0]->getValue());
     }
 
     public function testGetDescription()