Merge branch '2.5'

* 2.5:
  Bump versions of Swagger UI, GraphiQL and GraphQL Playground and improve contrib instructions
  Update changelog
  Fix a bug preventing to serialize validator's payload (#3375)
  Ignore FOSUser deprecations only
  Fix tests (#3506)
  Stop suggestion FOSUser, it harms more than it helps
  Changelog for 2.5.5

Author: dunglas

.github/workflows/ci.yml

@@ -2008,7 +2008,7 @@ jobs:
       fail-fast: false
     timeout-minutes: 20
     env:
-      SYMFONY_DEPRECATIONS_HELPER: max[total]=8 # 5 deprecation notices from FOSUserBundle
+      SYMFONY_DEPRECATIONS_HELPER: max[total]=5
     steps:
       - name: Checkout
         uses: actions/checkout@v1

.gitignore

@@ -9,4 +9,5 @@
 /swagger.json
 /swagger.yaml
 /tests/Fixtures/app/var/
+/tests/Fixtures/app/public/bundles/
 /vendor/

CHANGELOG.md

@@ -10,15 +10,34 @@
 * OpenAPI: Add PHP default values to the documentation (#2386)
 * Deprecate using a validation groups generator service not implementing `ApiPlatform\Core\Bridge\Symfony\Validator\ValidationGroupsGeneratorInterface` (#3346)
 
-## 2.5.x-dev
-
-* GraphQL: Do not allow empty cursor values on `before` or `after`
-* Filter: Improve the RangeFilter query in case the values are equals using the between operator
+## 2.5.5
+
+* Filter: Improve the RangeFilter query in case the values are equals using the between operator #3488
+* Pagination: Fix bug with large values #3451
+* Doctrine: use the correct type within `setParameter` of the SearchFilter #3331
+* Allow `\Traversable` resources #3463
+* Hydra: `hydra:writable` => `hydra:writeable` #3481
+* Hydra: Show `hydra:next` only when it's available #3457
+* Swagger UI: Missing default context argument #3443
+* Swagger UI: Fix API docs path in swagger ui #3475
+* OpenAPI: Export with unescaped slashes #3368
+* OpenAPI: OAuth flows fix #3333
+* JSON Schema: Fix metadata options #3425
+* JSON Schema: Allow decoration #3417
+* JSON Schema: Add DateInterval type #3351
+* JSON Schema: Correct schema generation for many types #3402
+* Validation: Use API Platform's `ValidationException` instead of Symfony's #3414
+* Validation: Fix a bug preventing to serialize validator's payload #3375
+* Subresources: Improve queries when there's only one level #3396
+* HTTP: Location header is only set on POST with a 201 or between 300 and 400 #3497
+* GraphQL: Do not allow empty cursor values on `before` or `after` #3360
+* Bump versions of Swagger UI, GraphiQL and GraphQL Playground #3510
+>>>>>>> 2.5
 
 ## 2.5.4
 
 * Add a local cache in `ResourceClassResolver::getResourceClass()`
-* JSON Schema: Fix  generation for non-resource class
+* JSON Schema: Fix generation for non-resource class
 * Doctrine: Get class metadata only when it's needed in `SearchFilter`
 * GraphQL: Better detection of collection type
 

CONTRIBUTING.md

@@ -25,14 +25,29 @@ Then, if it appears that it's a real bug, you may report it using GitHub by foll
 First of all, you must decide on what branch your changes will be based depending of the nature of the change.
 See [the dedicated documentation entry](https://api-platform.com/docs/extra/releases/).
 
+To prepare your patch directly in the `vendor/` of an existing project (convenient to fix a bug):
+
+1. Remove the existing copy of the library: `rm -Rf vendor/api-platform/core`
+2. Reinstall the lib while keeping Git metadata: `composer install --prefer-source`
+3. You can now work directly in `vendor/api-platform/core`, create a new branch: `git checkout -b my_patch`
+4. When your patch is ready, fork the project and add your Git remote: `git remote add <your-name> [email protected]:<your-name>/core.git`
+5. You can now push your code and open your Pull Request: `git push <your-name> my_patch`
+
+Alternatively, you can also work with the test application we provide:
+
+    cd tests/Fixtures/app
+    ./console assets:install --symlink
+    symfony serve
+    
+    # or if you prefer using the PHP built-in web server
+    php -S localhost:8000 -t public/
+
 ### Matching Coding Standards
 
 The API Platform project follows [Symfony coding standards](https://symfony.com/doc/current/contributing/code/standards.html).
 But don't worry, you can fix CS issues automatically using the [PHP CS Fixer](https://cs.sensiolabs.org/) tool:
 
-```shell
-php-cs-fixer.phar fix
-```
+    php-cs-fixer.phar fix
 
 And then, add the fixed file to your commit before pushing.
 Be sure to add only **your modified files**. If any other file is fixed by cs tools, just revert it before committing.
@@ -59,45 +74,33 @@ Both `phpunit` and `behat` are development dependencies and should be available
 
 To launch unit tests:
 
-```shell
-vendor/bin/phpunit --stop-on-failure -vvv
-```
+    vendor/bin/phpunit --stop-on-failure -vvv
 
-If you want coverage, you will need the `phpdbg` package and run:
+If you want coverage, you will need the `pcov` PHP extension and run:
 
-```shell
-phpdbg -qrr vendor/bin/phpunit --coverage-html coverage -vvv --stop-on-failure
-```
+    vendor/bin/phpunit --coverage-html coverage -vvv --stop-on-failure
 
 Sometimes there might be an error with too many open files when generating coverage. To fix this, you can increase the `ulimit`, for example:
 
-```shell
-ulimit -n 4000
-```
+    ulimit -n 4000
 
 Coverage will be available in `coverage/index.html`.
 
 #### Behat
 
 The command to launch Behat tests is:
 
-```shell
-./vendor/bin/behat --suite=default --stop-on-failure -vvv
-```
+    ./vendor/bin/behat --suite=default --stop-on-failure -vvv
 
 If you want to launch Behat tests for MongoDB, the command is:
 
-```shell
-APP_ENV=mongodb ./vendor/bin/behat --suite=mongodb --stop-on-failure -vvv
-```
+    APP_ENV=mongodb ./vendor/bin/behat --suite=mongodb --stop-on-failure -vvv
 
 ## Squash your Commits
 
 If you have 3 commits, start with:
 
-```shell
-git rebase -i HEAD~3
-```
+    git rebase -i HEAD~3
 
 An editor will be opened with your 3 commits, all prefixed by `pick`.
 
@@ -109,15 +112,11 @@ After that, all your commits will be squashed into the first one and the commit
 
 If you would like to rename your commit message, type:
 
-```shell
-git commit --amend
-```
+    git commit --amend
 
 Now force push to update your PR:
 
-```shell
-git push --force-with-lease
-```
+    git push --force-with-lease
 
 # License and Copyright Attribution
 
@@ -127,3 +126,13 @@ and to transfer the copyright on the submitted code to Kévin Dunglas.
 Be sure to you have the right to do that (if you are a professional, ask your company)!
 
 If you include code from another project, please mention it in the Pull Request description and credit the original author.
+
+# Releases
+
+This section is dedicated to maintainers.
+
+1. Update the JavaScript dependencies by running `./update-js.sh` (always check if it works in a browser)
+2. Update the `CHANGELOG.md` file (be sure to include Pull Request numbers when appropriate)
+3. Create a signed tag: `git tag -s vX.Y.Z -m "Version X.Y.Z"`
+4. Create a release using GitHub's UI and copy the changelog 
+5. Create a new release of `api-platform/api-platform`

composer.json

@@ -42,7 +42,7 @@
         "doctrine/mongodb-odm-bundle": "^4.0",
         "doctrine/orm": "^2.6.4",
         "elasticsearch/elasticsearch": "^6.0",
-        "friendsofsymfony/user-bundle": "^2.2@dev",
+        "friendsofsymfony/user-bundle": "2.2.x-dev#157b53bd7d6c347148a90e723981a43f9c897bf5",
         "guzzlehttp/guzzle": "^6.0",
         "jangregor/phpstan-prophecy": "^0.6",
         "justinrainbow/json-schema": "^5.2.1",
@@ -97,7 +97,6 @@
     "suggest": {
         "doctrine/mongodb-odm-bundle": "To support MongoDB. Only versions 4.0 and later are supported.",
         "elasticsearch/elasticsearch": "To support Elasticsearch.",
-        "friendsofsymfony/user-bundle": "To use the FOSUserBundle bridge.",
         "guzzlehttp/guzzle": "To use the HTTP cache invalidation system.",
         "phpdocumentor/reflection-docblock": "To support extracting metadata from PHPDoc.",
         "psr/cache-implementation": "To use metadata caching.",

src/Bridge/Symfony/Bundle/DependencyInjection/Configuration.php

@@ -96,7 +96,7 @@ public function getConfigTreeBuilder()
                 ->arrayNode('validator')
                     ->addDefaultsIfNotSet()
                     ->children()
-                        ->variableNode('serialize_payload_fields')->defaultValue([])->info('Enable the serialization of payload fields when a validation error is thrown.')->end()
+                        ->variableNode('serialize_payload_fields')->defaultValue([])->info('Set to null to serialize all payload fields when a validation error is thrown, or set the fields you want to include explicitly.')->end()
                     ->end()
                 ->end()
                 ->arrayNode('eager_loading')