Bump PHPStan version

and fix a mistake in a readme

Author: antograssiot

.circleci/config.yml

@@ -110,7 +110,7 @@ jobs:
       - *update-project-dependencies
       - run:
           name: Install PHPStan
-          command: composer global require phpstan/phpstan:0.10.1
+          command: composer global require phpstan/phpstan:0.10.5
       - *save-composer-cache-by-revision
       - *save-composer-cache-by-branch
       - run:

appveyor.yml

@@ -19,7 +19,7 @@ install:
   - echo extension=php_pdo_sqlite.dll >> php.ini
   - echo memory_limit=3G >> php.ini
   - cd %APPVEYOR_BUILD_FOLDER%
-  - composer install --no-interaction --no-progress
+  - composer install --no-interaction --no-progress --no-suggest
 
 test_script:
   - cd %APPVEYOR_BUILD_FOLDER%

features/security/README.md

@@ -60,7 +60,7 @@ one of the most popular framework validation in the world.
 
 The sending of security headers is ensured by [our "send security headers" functional test suite](send_security_headers.feature)
 and the unit tests of the [`RespondListener`](../../tests/EventListener/RespondListenerTest.php), [`ExceptionAction`](../../tests/Action/ExceptionActionTest.php)
-and [`ValidationExceptionListener`](../../tests/Bridge/Symfony/Validation/EventListener/ValidationExceptionListenerTest.php).
+and [`ValidationExceptionListener`](../../tests/Bridge/Symfony/Validator/EventListener/ValidationExceptionListenerTest.php).
 
 ### JSON encoding
 

phpstan.neon

@@ -8,6 +8,7 @@ parameters:
     ignoreErrors:
         # Real problems, hard to fix
         - '#Parameter \#2 \$dqlPart of method Doctrine\\ORM\\QueryBuilder::add\(\) expects array\|object, string given\.#'
+        - '#Call to function method_exists\(\) with .Doctrine.+ and .get(Join|Alias|Parts). will always evaluate to false\.#'
 
         # False positives
         - '#Access to an undefined property Prophecy\\Prophecy\\ObjectProphecy::\$[a-zA-Z0-9_]+#'

src/DataProvider/SubresourceDataProviderInterface.php

@@ -32,7 +32,7 @@ interface SubresourceDataProviderInterface
      *
      * @throws ResourceClassNotSupportedException
      *
-     * @return object|null
+     * @return array|object|null
      */
     public function getSubresource(string $resourceClass, array $identifiers, array $context, string $operationName = null);
 }

src/GraphQl/Type/Definition/IterableType.php

@@ -20,6 +20,7 @@
 use GraphQL\Language\AST\ListValueNode;
 use GraphQL\Language\AST\ObjectValueNode;
 use GraphQL\Language\AST\StringValueNode;
+use GraphQL\Language\AST\ValueNode;
 use GraphQL\Type\Definition\ScalarType;
 use GraphQL\Utils\Utils;
 
@@ -80,7 +81,7 @@ public function parseLiteral($valueNode, array $variables = null)
     }
 
     /**
-     * @param StringValueNode|BooleanValueNode|IntValueNode|FloatValueNode|ObjectValueNode|ListValueNode $valueNode
+     * @param StringValueNode|BooleanValueNode|IntValueNode|FloatValueNode|ObjectValueNode|ListValueNode|ValueNode $valueNode
      */
     private function parseIterableLiteral($valueNode)
     {

src/Swagger/Serializer/DocumentationNormalizer.php

@@ -263,10 +263,7 @@ private function updateGetOperation(\ArrayObject $pathOperation, array $mimeType
                     ],
                 ],
             ];
-
-            if (!isset($pathOperation['parameters']) && $parameters = $this->getFiltersParameters($resourceClass, $operationName, $resourceMetadata, $definitions, $serializerContext)) {
-                $pathOperation['parameters'] = $parameters;
-            }
+            $pathOperation['parameters'] ?? $pathOperation['parameters'] = $this->getFiltersParameters($resourceClass, $operationName, $resourceMetadata, $definitions, $serializerContext);
 
             if ($this->paginationEnabled && $resourceMetadata->getCollectionOperationAttribute($operationName, 'pagination_enabled', true, true)) {
                 $pathOperation['parameters'][] = $this->getPaginationParameters();

tests/Metadata/Property/Factory/InheritedPropertyNameCollectionFactoryTest.php

@@ -34,7 +34,7 @@ public function testCreate()
 
         $propertyNameCollectionFactory = $this->prophesize(PropertyNameCollectionFactoryInterface::class);
         $propertyNameCollectionFactory->create(DummyTableInheritance::class, [])->willReturn(new PropertyNameCollection(['name']))->shouldBeCalled();
-        $propertyNameCollectionFactory->create(DummyTableInheritanceChild::class, [])->willReturn(new PropertyNameCollection(['nickname', 169]))->shouldBeCalled();
+        $propertyNameCollectionFactory->create(DummyTableInheritanceChild::class, [])->willReturn(new PropertyNameCollection(['nickname', '169']))->shouldBeCalled();
 
         $factory = new InheritedPropertyNameCollectionFactory($resourceNameCollectionFactory->reveal(), $propertyNameCollectionFactory->reveal());
         $metadata = $factory->create(DummyTableInheritance::class);