Remove compatibility layer for bad identifiers 404 through PropertyNotFound

Author: abluchet

src/Bridge/Symfony/Routing/IriConverter.php

@@ -81,16 +81,16 @@ public function getItemFromIri(string $iri, array $context = [])
 
         $attributes = AttributesExtractor::extractAttributes($parameters);
 
-        if ($this->identifierDenormalizer) {
-            $context[ChainIdentifierDenormalizer::HAS_IDENTIFIER_DENORMALIZER] = true;
-        }
-
         try {
             $identifiers = $this->extractIdentifiers($parameters, $attributes);
         } catch (InvalidIdentifierException $e) {
             throw new InvalidArgumentException($e->getMessage(), $e->getCode(), $e);
         }
 
+        if ($this->identifierDenormalizer) {
+            $context[ChainIdentifierDenormalizer::HAS_IDENTIFIER_DENORMALIZER] = true;
+        }
+
         if (isset($attributes['subresource_operation_name'])) {
             if ($item = $this->getSubresourceData($identifiers, $attributes, $context)) {
                 return $item;

src/DataProvider/OperationDataProviderTrait.php

@@ -14,7 +14,6 @@
 namespace ApiPlatform\Core\DataProvider;
 
 use ApiPlatform\Core\Exception\InvalidIdentifierException;
-use ApiPlatform\Core\Exception\PropertyNotFoundException;
 use ApiPlatform\Core\Exception\RuntimeException;
 use ApiPlatform\Core\Identifier\Normalizer\ChainIdentifierDenormalizer;
 
@@ -62,11 +61,7 @@ private function getCollectionData(array $attributes, array $context)
      */
     private function getItemData($identifiers, array $attributes, array $context)
     {
-        try {
-            return $this->itemDataProvider->getItem($attributes['resource_class'], $identifiers, $attributes['item_operation_name'], $context);
-        } catch (PropertyNotFoundException $e) {
-            return null;
-        }
+        return $this->itemDataProvider->getItem($attributes['resource_class'], $identifiers, $attributes['item_operation_name'], $context);
     }
 
     /**