Merge pull request #1124 from soyuka/fix/1122

Swagger documentation normalizer revert throw when method is not supp…

Author: dunglas

src/Swagger/Serializer/DocumentationNormalizer.php

@@ -18,7 +18,6 @@
 use ApiPlatform\Core\Api\ResourceClassResolverInterface;
 use ApiPlatform\Core\Api\UrlGeneratorInterface;
 use ApiPlatform\Core\Documentation\Documentation;
-use ApiPlatform\Core\Exception\RuntimeException;
 use ApiPlatform\Core\Metadata\Property\Factory\PropertyMetadataFactoryInterface;
 use ApiPlatform\Core\Metadata\Property\Factory\PropertyNameCollectionFactoryInterface;
 use ApiPlatform\Core\Metadata\Property\PropertyMetadata;
@@ -170,9 +169,9 @@ private function getPathOperation(string $operationName, array $operation, strin
                 return $this->updatePutOperation($pathOperation, $mimeTypes, $collection, $resourceMetadata, $resourceClass, $resourceShortName, $operationName, $definitions);
             case 'DELETE':
                 return $this->updateDeleteOperation($pathOperation, $resourceShortName);
-            default:
-                throw new RuntimeException(sprintf('Method "%s" is not supported', $method));
         }
+
+        return $pathOperation;
     }
 
     /**

tests/Swagger/Serializer/DocumentationNormalizerTest.php

@@ -1105,11 +1105,7 @@ public function testNoOperations()
         $this->assertEquals($expected, $normalizer->normalize($documentation));
     }
 
-    /**
-     * @expectedException \ApiPlatform\Core\Exception\RuntimeException
-     * @expectedMessage Method "foo" is not supported
-     */
-    public function testMethodNotSupported()
+    public function testWithCustomMethod()
     {
         $documentation = new Documentation(new ResourceNameCollection([Dummy::class]), '', '', '0.0.0', ['jsonld' => ['application/ld+json']]);
 
@@ -1135,6 +1131,7 @@ public function testMethodNotSupported()
         $operationMethodResolverProphecy->getCollectionOperationMethod(Dummy::class, 'get')->shouldBeCalled()->willReturn('FOO');
 
         $urlGeneratorProphecy = $this->prophesize(UrlGeneratorInterface::class);
+        $urlGeneratorProphecy->generate('api_entrypoint')->willReturn('/')->shouldBeCalled();
 
         $operationPathResolver = new CustomOperationPathResolver(new UnderscoreOperationPathResolver());
 
@@ -1148,7 +1145,24 @@ public function testMethodNotSupported()
             $urlGeneratorProphecy->reveal()
         );
 
-        $normalizer->normalize($documentation);
+        $expected = [
+            'swagger' => '2.0',
+            'basePath' => '/',
+            'info' => [
+                'title' => '',
+                'version' => '0.0.0',
+            ],
+            'paths' => new \ArrayObject([
+                '/dummies' => [
+                    'foo' => new \ArrayObject([
+                        'tags' => ['Dummy'],
+                        'operationId' => 'getDummyCollection',
+                    ]),
+                ],
+            ]),
+        ];
+
+        $this->assertEquals($expected, $normalizer->normalize($documentation));
     }
 
     public function testNormalizeWithNestedNormalizationGroups()