Skip to content

Fix #1008 multiple filters on eager loading #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2017

Conversation

soyuka
Copy link
Member

@soyuka soyuka commented Mar 24, 2017

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #1008
License MIT
Doc PR na

@soyuka
Copy link
Member Author

soyuka commented Mar 24, 2017

@bschultz @antograssiot may you try this patch? I added a behat test (with date filter that does an orWhere and a boolean filter andWhere) so this should be good to go, just want to be sure :).

Thanks!

@soyuka soyuka force-pushed the fix-multiple-filters branch from c954495 to 905c981 Compare March 24, 2017 13:55
@bschultz
Copy link

@soyuka Yes with this patch it works :) 👍

@dunglas dunglas merged commit ecf05eb into api-platform:2.0 Mar 24, 2017
@dunglas
Copy link
Member

dunglas commented Mar 24, 2017

Thanks for the fix!

@soyuka soyuka deleted the fix-multiple-filters branch March 24, 2017 14:46
hoangnd25 pushed a commit to hoangnd25/core that referenced this pull request Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants