Skip to content

Switch to 3.3 stable #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2017
Merged

Switch to 3.3 stable #1146

merged 1 commit into from
Jun 1, 2017

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented May 30, 2017

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

meyerbaptiste
meyerbaptiste requested changes May 30, 2017
View reviewed changes
composer.json
"symfony/form": "^3.3@beta",
"symfony/framework-bundle": "^3.3@beta",
"symfony/finder": "^3.3",
"symfony/form": "^3.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed.

@meyerbaptiste
Copy link
Member

I bumped a lot of dependencies because of stability requirements but should we not downgrade to older versions?

  • "symfony/http-foundation": "^3.1"
  • "symfony/asset": "^2.7 || ^3.0"
  • "symfony/cache": "^3.1"
  • "symfony/config": "^3.2"
  • "symfony/event-dispatcher": "^2.7 || ^3.0"
  • "symfony/finder": "^2.7 || ^3.0"
  • etc.

Then, IMO, a dev dependency is missing:

  • "symfony/debug": "^2.8 || ^3.0", because we use the Symfony\Component\Debug\Exception\FlattenException exception.

@Simperfit
Copy link
Contributor

I agree with @meyerbaptiste we could keep some low deps

@dunglas
Copy link
Member Author

dunglas commented Jun 1, 2017

Done @meyerbaptiste @Simperfit

@dunglas dunglas merged commit a8a7c42 into api-platform:master Jun 1, 2017
@dunglas dunglas deleted the 33_stable branch June 1, 2017 07:45
hoangnd25 pushed a commit to hoangnd25/core that referenced this pull request Feb 23, 2018
@dunglas
Merge pull request api-platform#1146 from dunglas/33_stable
84bf353 
Switch to 3.3 stable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meyerbaptiste meyerbaptiste meyerbaptiste requested changes

@soyuka soyuka soyuka approved these changes

@Simperfit Simperfit Simperfit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dunglas @meyerbaptiste @Simperfit @soyuka