Add a data persistence layer #1464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyerbaptiste
force-pushed
the
add_data_persister
branch
from
6977d8a to
8103766
Compare
dunglas
requested changes
Oct 27, 2017
| */ | ||
| public function supports($data): bool | ||
| { | ||
| return (bool) $this->getManager($data); |
There was a problem hiding this comment.
Wouldn't null !== $this->getManager($data) be less weird?
| @@ -1,87 +0,0 @@ | |||
| <?php | |||
There was a problem hiding this comment.
We cannot drop it right now (BC promise), this class must be deprecated instead.
There was a problem hiding this comment.
So should we also keep the definition of the tagged service and depreciate it?
There was a problem hiding this comment.
I'm not sure about that because it's a public service so it will always be executed.
| /** | ||
| * Registers data persisters. | ||
| * | ||
| * @internal |
There was a problem hiding this comment.
We'll be able to drop this class when we'll upgrade to DI 3.4: http://symfony.com/blog/new-in-symfony-3-4-simpler-injection-of-tagged-services
meyerbaptiste
force-pushed
the
add_data_persister
branch
4 times, most recently
from
6e4d207 to
8bba007
Compare
meyerbaptiste
force-pushed
the
add_data_persister
branch
from
8bba007 to
c8f5c64
Compare
|
Done @dunglas |
dunglas
approved these changes
Oct 30, 2017
|
Thanks @meyerbaptiste |
|
Don't forget the docs PR :D |
4 tasks
hoangnd25
pushed a commit
to hoangnd25/core
that referenced
this pull request
Feb 23, 2018
…ister Add a data persistence layer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.