Restore the Postgres tests #1544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dunglas
commented
Dec 5, 2017
dunglas
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
soyuka
reviewed
Dec 5, 2017
.travis.yml
Outdated
| @@ -52,7 +52,7 @@ install: | |||
| script: | |||
| - vendor/bin/phpunit | |||
| - if [[ $APP_ENV != 'postgres' ]]; then vendor/bin/behat --format=progress; fi | |||
| - if [[ $APP_ENV = 'postgres' ]]; then vendor/bin/behat --tags='~@sqlite||@postgres' --format=progress; fi | |||
| - if [[ $APP_ENV = 'postgres' ]]; then vendor/bin/behat --tags='~@sqlite' --format=progress; fi | |||
There was a problem hiding this comment.
note that postgres tags are filtered by default in the behat.yml.dist now.
There was a problem hiding this comment.
You mean I need to restore ~@sqlite||@postgres?
There was a problem hiding this comment.
I think it's good like this because CLI defined tags are replacing the ones from the config !
soyuka
approved these changes
Dec 5, 2017
dunglas
added a commit
that referenced
this pull request
Dec 5, 2017
hoangnd25
pushed a commit
to hoangnd25/core
that referenced
this pull request
Feb 23, 2018
hoangnd25
pushed a commit
to hoangnd25/core
that referenced
this pull request
Feb 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.