Improved joins when using the properties filter #1552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
requested review from
soyuka and
meyerbaptiste
and removed request for
soyuka
soyuka
reviewed
Dec 7, 2017
| false === $propertyMetadata->getAttribute('fetchEager', false) && | ||
| ( | ||
| false === $propertyMetadata->isReadable() || | ||
| ((!$useAttributes && $isNotReadableLink) || ($useAttributes && !$inAttributes)) |
There was a problem hiding this comment.
linter has an issue with inAttributes anyway it's fine to me. Glad to see the EagerLoading extension serve it's purpose :D.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #1546. This PR allows API Platform to add useful SQL
JOINclauses and to remove the useless ones according to properties selected by the client using the property filter.That's a massive performance improvement when using this filter.
I'll also use this feature later to improve the generated SQL queries when using GraphQL. It will allow to only fetch what is required for a given GraphQL query while to reducing dramatically the number of issued SQL queries for a whole GraphQL request.