Skip to content

Convert the route prefix attribute name to snake case #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2018

Conversation

meyerbaptiste
Copy link
Member

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

Indeed, all our attributes use snake case except this one.

cc @Toflar

Copy link
Contributor

@Toflar Toflar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry about that! That's true 👍

@Toflar
Copy link
Contributor

Toflar commented Mar 20, 2018

It's just a BC break for the ones already using it.

@meyerbaptiste
Copy link
Member Author

No BC break, this feature is not released yet!

@Toflar
Copy link
Contributor

Toflar commented Mar 20, 2018

Ah, I thought it was :D

@dunglas dunglas merged commit c11f03a into api-platform:master Mar 20, 2018
@dunglas
Copy link
Member

dunglas commented Mar 20, 2018

Thanks @meyerbaptiste

@meyerbaptiste meyerbaptiste deleted the snakecase_route_prefix branch March 20, 2018 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants