Remove useless try/catch in the CachedTrait #1931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simperfit
approved these changes
May 3, 2018
soyuka
approved these changes
May 3, 2018
|
thanks @meyerbaptiste |
bendavies
reviewed
May 5, 2018
| try { | ||
| $cacheItem->set($value); | ||
| $this->cacheItemPool->save($cacheItem); | ||
| } catch (CacheException $e) { |
There was a problem hiding this comment.
I was only copying exciting code in the previous pr so I am not sure of the original author's thoughts, but you are now keeping the exception handling above but removing this one. Should we be consistent?
There was a problem hiding this comment.
There is no chance of CacheException being thrown here. The original author (i.e. myself) was mistaken. 😆
There was a problem hiding this comment.
And we all copied without thinking twice 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I missed the #1908 review.