Fix some SensioLabs Insight violations #2068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dunglas
commented
Jul 4, 2018
dunglas
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
|
Shouldn't this have been done on |
|
All those classes are new ones. |
dunglas
commented
Jul 4, 2018
| $identifiers = CompositeIdentifierParser::parse($data); | ||
| } else { | ||
| } else if (0 === $numIdentifier) { |
| { | ||
| const HAS_IDENTIFIER_DENORMALIZER = 'has_identifier_denormalizer'; | ||
| const HAS_IDENTIFIER_CONVERTER = 'has_identifier_converter'; |
There was a problem hiding this comment.
Could be moved to the interface right?
There was a problem hiding this comment.
I'd prefer not to so that we can remove it later
soyuka
force-pushed
the
insight
branch
4 times, most recently
from
6729457 to
898b0e6
Compare
dunglas
commented
Jul 5, 2018
| } | ||
|
|
||
| if (\count($keys) > 1) { | ||
| if ($numIdentifiers = \count($keys) > 1) { |
There was a problem hiding this comment.
missing parenthesis: ($numIdentifiers = \count($keys))
soyuka
force-pushed
the
insight
branch
4 times, most recently
from
e055113 to
067eda1
Compare
|
Thanks @soyuka |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.