Skip to content

Webby easter egg #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 11, 2018
Merged

Conversation

alanpoulain
Copy link
Member

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets api-platform/api-platform#744
License MIT
Doc PR

Webby is a little more alive! 🕸️ Enjoy!

webby-alive

@@ -1,6 +1,21 @@
'use strict';

window.onload = () => {
const webby = document.getElementsByClassName('webby')[0];
const web = document.getElementsByClassName('web')[0];
webby.className += ' calm';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webby.classList.add('calm');

?

webby.className += ' calm';
web.className += ' calm';
webby.addEventListener('click', () => {
if (-1 === webby.className.indexOf('frighten')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (-1 !== webby.className.indexOf('frighten')) {
    return;
}

web.className += ' calm';
webby.addEventListener('click', () => {
if (-1 === webby.className.indexOf('frighten')) {
webby.className = webby.className.replace('calm', 'frighten');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webby.classList.replace('calm', 'frighten'); ? (same after)

@alanpoulain
Copy link
Member Author

Failing test is not related (seems to be a deprecated in Doctrine).

@alanpoulain alanpoulain merged commit deeaf29 into api-platform:master Sep 11, 2018
epourail pushed a commit to epourail/fork-apiplatform-core that referenced this pull request Sep 25, 2018
* Webby easter egg

* Fix style and name

* Fix review comments
soyuka pushed a commit to CvekCoding/core that referenced this pull request Nov 2, 2018
* Webby easter egg

* Fix style and name

* Fix review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants