[EagerLoadingExtension] Remove unset attributes key in normalization context #2279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
approved these changes
Oct 25, 2018
soyuka
reviewed
Oct 25, 2018
| @@ -167,8 +167,6 @@ private function joinRelations(QueryBuilder $queryBuilder, QueryNameGeneratorInt | |||
| if ($inAttributes = isset($normalizationContext[AbstractNormalizer::ATTRIBUTES][$association])) { | |||
| // prepare the child context | |||
| $normalizationContext[AbstractNormalizer::ATTRIBUTES] = $normalizationContext[AbstractNormalizer::ATTRIBUTES][$association]; | |||
| } else { | |||
| unset($normalizationContext[AbstractNormalizer::ATTRIBUTES]); | |||
There was a problem hiding this comment.
@dunglas I think you added this but it does not look useful to me, I'd be 👍 for this patch, any reason we should keep this?
|
Thanks Thibaut! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an entity had more that one relation, if the first relation was not present in the attributes array in the normalization context the whole array was removed so they was no test for other relations on the next loop iteration.
The aim of this pull request is to fix this behavior and to let the chance to other relations to be eager loaded.