Skip to content

Fix Doctrine DataPersister priority #2392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Dec 18, 2018

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

This allows to leverage the autoconfigure flag when creating custom data providers. Without this explicit priority, the default provider can be registered before custom ones, which is counter-intuitive and annoying.

This is a potential (tiny) BC break (it's why I not targeted 2.3), but I think it is worth it.

Copy link
Contributor

@antograssiot antograssiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth documenting in an UPGRADE-2.4 ?

@dunglas
Copy link
Member Author

dunglas commented Dec 19, 2018

@antograssiot I'll add it to the changelog

@dunglas dunglas merged commit 1638d79 into api-platform:master Dec 19, 2018
@dunglas dunglas deleted the fix_doctrine_datapersister_priority branch December 19, 2018 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants