Simplify ExistsFilter declaration #2722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antograssiot
force-pushed
the
existsfilter
branch
2 times, most recently
from
0dc2978 to
12e3b94
Compare
teohhanhui
suggested changes
Apr 10, 2019
antograssiot
force-pushed
the
existsfilter
branch
from
12e3b94 to
544603b
Compare
antograssiot
force-pushed
the
existsfilter
branch
from
544603b to
24f574d
Compare
|
Failing tests are likely not related and were fixed by @teohhanhui in https://github.com/api-platform/core/pull/2744/files#diff-762fac8fef8061a4affa4d35df9c45c7R846 |
teohhanhui
approved these changes
Apr 19, 2019
|
@antograssiot Needs a rebase, then everything should be green? 😄 |
antograssiot
force-pushed
the
existsfilter
branch
from
24f574d to
b7f45ef
Compare
|
here you are, all green 😄 |
|
Thanks @antograssiot! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to provide an alternative to #2640
As i'm working on supporting name converters in filters, adding another optional argument is way harder now, so i went with what have been done in #1844