Skip to content

Fix autoregister ODM extensions #3076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2019
Merged

Fix autoregister ODM extensions #3076

merged 2 commits into from
Sep 17, 2019

Conversation

markitosgv
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #3075
License MIT

Fix custom doctrine ODM extension loading

$container->registerForAutoconfiguration(AggregationCollectionExtensionInterface::class)
->addTag('api_platform.doctrine.mongodb.aggregation_extension.collection');
->addTag('api_platform.doctrine_mongodb.odm.aggregation_extension.collection');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks about the fix @markitosgv ! Could you update the tests accordingly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure ;-)

@soyuka soyuka merged commit 19f238b into api-platform:2.4 Sep 17, 2019
@soyuka
Copy link
Member

soyuka commented Sep 17, 2019

many thanks @markitosgv !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants