Skip to content

Add entrypoints sorting #3114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Conversation

mRoca
Copy link
Contributor

@mRoca mRoca commented Sep 27, 2019

Q A
Bug fix? yes
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets #3091
License MIT
Doc PR

As described in #3091, the main entrypoint returns resources names without any coherent sorting, as it can change depending of your get_declared_classes() returned values order.

Caution : this can be a BC break as tests can fail for existing projects.

@mRoca mRoca force-pushed the entrypoints-sorting branch from a52b378 to 854bcc9 Compare September 27, 2019 09:37
@soyuka soyuka merged commit 8e28a58 into api-platform:master Sep 30, 2019
@soyuka
Copy link
Member

soyuka commented Sep 30, 2019

thanks @mRoca !

@mRoca mRoca deleted the entrypoints-sorting branch September 30, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants