DI: Improve swagger versions parameter (fix #3115) #3167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
soyuka
commented
Oct 11, 2019
soyuka
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #3115 |
| License | MIT |
| Doc PR | api-platform/docs#1234 |
teohhanhui
reviewed
Oct 11, 2019
soyuka
force-pushed
the
fix-swagger-versions
branch
2 times, most recently
from
5d19d84 to
b4adb0e
Compare
dunglas
requested changes
Oct 14, 2019
src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php
Outdated
Show resolved
Hide resolved
soyuka
force-pushed
the
fix-swagger-versions
branch
3 times, most recently
from
aaa938c to
c91b056
Compare
soyuka
force-pushed
the
fix-swagger-versions
branch
2 times, most recently
from
6fc5138 to
9a5cf95
Compare
teohhanhui
reviewed
Oct 22, 2019
| @@ -344,6 +345,10 @@ private function registerJsonLdHydraConfiguration(ContainerBuilder $container, a | |||
| return; | |||
| } | |||
|
|
|||
| if (!$container->has('api_platform.json_schema.schema_factory')) { | |||
| $container->removeDefinition('api_platform.hydra.json_schema.schema_factory'); | |||
There was a problem hiding this comment.
You cannot remove a definition when it doesn't exist yet (it's defined in hydra.xml loaded few lines below)...
$loader->load('hydra.xml');
soyuka
force-pushed
the
fix-swagger-versions
branch
from
9a5cf95 to
3cab522
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.