Additional properties: false to allow better type checking from JSON schemas #3388
Conversation
|
You should fix the CS too 🙂 |
|
Done! I was double checking the failing tests as well but it seems unrelated. |
|
Let's wait for #3402 first, as it'll make use of |
|
@teohhanhui is there anything I can do to speed up the merging process? Having this change merged and released would highly reduce the bug risks in my production-deployed TypeScript consumers. |
|
@quentinus95 we need to progress at our own pace :|. You should be able to use your fork (and this patch) by tweaking the |
|
@soyuka sure! It was just to be 100% sure nothing more was required on my side. |
|
@teohhanhui any feedback now that #3402 has been merged? |
|
could you rebase? thanks! |
| @@ -110,6 +110,7 @@ public function buildSchema(string $className, string $format = 'json', string $ | |||
| } | |||
|
|
|||
| $definition = new \ArrayObject(['type' => 'object']); | |||
| $definition['additionalProperties'] = false; | |||
There was a problem hiding this comment.
We should set this flag only if the allow_extra_attributes normalization context option is set to false: #1217
|
Thanks @quentinus95 ! Superseeded by #3804 |
This change sets additional properties to false on all definitions so developers using code generators (e.g. TypeScript code generators from JSON schema) can have safer type checks.