Skip to content

Fix tests and PHPStan #3561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2020
Merged

Fix tests and PHPStan #3561

merged 1 commit into from
May 18, 2020

Conversation

alanpoulain
Copy link
Member

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

@alanpoulain alanpoulain merged commit 563e017 into api-platform:2.5 May 18, 2020
@alanpoulain alanpoulain deleted the fix-ci branch May 18, 2020 15:28
This was referenced May 27, 2020
Closed
Closed
@kralos
Copy link
Contributor

kralos commented May 27, 2020 •
edited
Loading

the tests for Behat (PHP 7.1) and Behat (PHP 7.x) (lowest dependencies) are still broken. This is because support for "taxon" wasn't added to doctrine/inflector until 1.4.0.

Restricting doctrine/inflector versions because of a test case would be a bit crappy. The simplest way to fix this is to stop using "taxon" and use a word doctrine/inflector ^1.0 can pluralize properly.

Note we are getting deprecation warnings:

The "Doctrine\Common\Inflector\Inflector::tableize" method is deprecated and will be dropped in doctrine/inflector 2.0. Please update to the new Inflector API.

This was deprecated in doctrine/inflector 1.4.0, Perhaps we shouldn't fail ci because of deprecations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanpoulain @kralos