Fix/identifier encode #3611
Merged
Fix/identifier encode #3611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
force-pushed
the
fix/identifier-encode
branch
from
0489781 to
5a41443
Compare
|
Thanks for taking over this PR @soyuka ! |
soyuka
force-pushed
the
fix/identifier-encode
branch
from
5a41443 to
be679e2
Compare
soyuka
force-pushed
the
fix/identifier-encode
branch
from
be679e2 to
acfcd13
Compare
|
thanks @silverbackdan ! |
|
@soyuka do you think we can have a release with this fix included? |
|
Version 2.6 when released will include this fix - for now you could use version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks as though the url encoding was not necessary and caused duplicate encoding in any case. The example I have tested originally returned
%253Ain place of the colon, which is the percent sign of %3A re-encoding.This fix removes all URL encoding, it doesn't appear necessary in the IRI converter.
Would this class as a BC change instead of a fix though? Is it better to drill down further and still url encode the IRI once?
From #3552