Skip to content

Update OpenApi PathItem nullable operation test #4122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2021
Merged

Update OpenApi PathItem nullable operation test #4122

merged 2 commits into from
Mar 8, 2021

Conversation

d0niek
Copy link
Contributor

@d0niek d0niek commented Mar 8, 2021

Previous test didn't test with* methods because they return new
(cloned) instance of $pathItem. In assertions we test nulls from
PathItem::_construct() instead of from with* methods.

@d0niek
Update OpenApi PathItem nullable operation test
3b8ee6d 
Previous test didn't test `with*` methods because they return new
(cloned) instance of `$pathItem`. In assertions we test nulls from
`PathItem::_construct()` instead of from `with*` methods.
d0niek referenced this pull request Mar 8, 2021
@soyuka
OpenAPI PathItem Add test nullable operation
c25f961
@alanpoulain alanpoulain merged commit cd2e35c into api-platform:2.6 Mar 8, 2021
@alanpoulain
Copy link
Member

Thank you @d0niek.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanpoulain alanpoulain alanpoulain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d0niek @alanpoulain