You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You can now hack in the cloned repository of `api-platform-admin`.
33
+
You can now hack in the cloned repository of `client-generator`. If you want to test your work, a `lib/index.js` file containing your last changes will be created each time you invoke `yarn build`. You can also use `yarn watch` to make it created each time a change is performed in your code!
48
34
49
35
### Testing your changes
50
36
51
37
Before sending a Pull Request, make sure the tests pass correctly:
52
38
53
-
```bash
54
-
yarn test
39
+
```console
40
+
$ yarn test
55
41
```
56
42
57
43
### Matching coding standards
58
44
59
-
The API Platform Admin project is inspired by the [Airbnb JavaScript style guide](https://github.com/airbnb/javascript).
45
+
The API Platform Client Generator project is inspired by the [Airbnb JavaScript style guide](https://github.com/airbnb/javascript).
60
46
But don't worry, you can fix CS issues automatically using [ESLint](https://eslint.org/) tool:
61
47
62
-
```bash
63
-
yarn fix
48
+
```console
49
+
$ yarn fix
64
50
```
65
51
66
52
And then, add fixed file to your commit before push.
@@ -70,11 +56,10 @@ Be sure to add only **your modified files**. If another files are fixed by cs to
70
56
71
57
When you send a PR, just make sure that:
72
58
73
-
* You add valid test cases (Behat and PHPUnit).
59
+
* You add valid test cases (you can run them using `yarn test`).
74
60
* Tests are green.
75
61
* You make a PR on the related documentation in the [api-platform/doc](https://github.com/api-platform/doc) repository.
76
-
* You make the PR on the same branch you based your changes on. If you see commits
77
-
that you did not make in your PR, you're doing it wrong.
62
+
* You make the PR on the same branch you based your changes on. If you see commits that you did not make in your PR, you're doing it wrong.
78
63
* Also don't forget to add a comment when you update a PR with a ping to [the maintainer](https://github.com/orgs/api-platform/people), so he/she will get a notification.
79
64
* Squash your commits into one commit. (see the next chapter)
80
65
@@ -97,8 +82,8 @@ All Pull Requests must include the following header:
97
82
98
83
If you have 3 commits. So start with:
99
84
100
-
```bash
101
-
git rebase -i HEAD~3
85
+
```console
86
+
$ git rebase -i HEAD~3
102
87
```
103
88
104
89
An editor will be opened with your 3 commits, all prefixed by `pick`.
@@ -111,34 +96,34 @@ After that, all your commits where squashed into the first one and the commit me
111
96
112
97
If you would like to rename your commit message type:
0 commit comments