Skip to content

Add global resources defaults entry #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

alanpoulain
Copy link
Member

@alanpoulain alanpoulain commented Feb 16, 2021

Documentation for api-platform/core#3151.

@alanpoulain alanpoulain merged commit cb64a61 into api-platform:2.6 Feb 16, 2021
@@ -90,40 +91,47 @@ api_platform:
order_parameter_name: 'order'

pagination:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should deprecate this whole section, isn't it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no resource-wide equivalent for some global parameters (like partial_parameter_name).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But shouldn't we uniformize and add them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense? I'm not sure having a resource-wide partial_parameter_name is a good idea for example. Having a parameter name depending of the resource is very error prone.
Anyway the choice has been made in this PR: api-platform/core#3151.
If we want to change it it will be for the 2.7 version isn't it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@@ -218,40 +226,44 @@ api_platform:
url:

http_cache:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this one too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same answer.

mercure:
# Enabled by default with installed symfony/mercure-bundle
# Enabled by default with installed symfony/mercure-bundle.
enabled: false

# The URL sent in the Link HTTP header. If not set, will default to MercureBundle's default hub URL.
hub_url: null

messenger:
Copy link
Member

@dunglas dunglas Feb 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this one...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want to deprecate this one.
Using it will remove all the messenger services whereas it's not the case for the defaults one. But we can change it.
As you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants