-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add global resources defaults entry #1287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global resources defaults entry #1287
Conversation
@@ -90,40 +91,47 @@ api_platform: | |||
order_parameter_name: 'order' | |||
|
|||
pagination: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should deprecate this whole section, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no resource-wide equivalent for some global parameters (like partial_parameter_name
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But shouldn't we uniformize and add them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense? I'm not sure having a resource-wide partial_parameter_name
is a good idea for example. Having a parameter name depending of the resource is very error prone.
Anyway the choice has been made in this PR: api-platform/core#3151.
If we want to change it it will be for the 2.7
version isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
@@ -218,40 +226,44 @@ api_platform: | |||
url: | |||
|
|||
http_cache: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this one too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same answer.
mercure: | ||
# Enabled by default with installed symfony/mercure-bundle | ||
# Enabled by default with installed symfony/mercure-bundle. | ||
enabled: false | ||
|
||
# The URL sent in the Link HTTP header. If not set, will default to MercureBundle's default hub URL. | ||
hub_url: null | ||
|
||
messenger: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this one...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we want to deprecate this one.
Using it will remove all the messenger services whereas it's not the case for the defaults
one. But we can change it.
As you wish.
Documentation for api-platform/core#3151.