Use php 8 attributes for Vich\UploadableBundle #1594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whole documentation for the version 2.7 is using the PHP attributes, so I feel, as Vich\UploadableBundle now supports them, we can use them for this bundle
dunglas
requested changes
Aug 14, 2022
Co-authored-by: Kévin Dunglas <[email protected]>
|
@dunglas suggestions added |
alanpoulain
approved these changes
Aug 16, 2022
|
Thanks @Xusifob. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whole documentation for the version 2.7 is using the PHP attributes, so I feel, as Vich\UploadableBundle now supports them, we can use them for this bundle