Add notice about custom entity identifier in data-providers.md #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add notice about custom entity identifier
soyuka
reviewed
Apr 11, 2017
core/data-providers.md
Outdated
| @@ -17,7 +17,7 @@ For a given resource, you can implement two kind of interfaces: | |||
| * the [`ItemDataProviderInterface`](https://github.com/api-platform/core/blob/master/src/DataProvider/ItemDataProviderInterface.php) | |||
| is used when fetching items. | |||
|
|
|||
| In the following examples we will create custom data providers for an entity class class called `AppBundle\Entity\BlogPost`. | |||
| In the following examples we will create custom data providers for an entity class class called `AppBundle\Entity\BlogPost`. Notice, that you need to set `identifier` attribute as it was described at [Entity Identifier Case](serialization-groups-and-relations.md#entity-identifier-case) section for your custom entity class to work properly. | |||
There was a problem hiding this comment.
WDYT about:
Note that if you entity is not doctrine-related, you need to flag the identifier property by using
@ApiProperty(identifiier=true)for things to work properly.
There was a problem hiding this comment.
Yes, I think your variant is better
|
Thanks @kate-kate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://github.com/api-platform/core/issues/1044