Enhance yaml-xml serialization groups configuration doc #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your help today @GregoireHebert ! |
core/getting-started.md
Outdated
| # api/config/packages/api_platform.yaml | ||
| api_platform: | ||
| mapping: | ||
| paths: ['%kernel.project_dir%/config/api_platform'] |
There was a problem hiding this comment.
I would also like to keep the default value:
paths:
- '%kernel.project_dir%/src/Entity'
- '%kernel.project_dir%/config/api_platform'There was a problem hiding this comment.
Agreed, Just added it :)
dunglas
previously requested changes
Mar 23, 2018
core/getting-started.md
Outdated
|
|
||
| You might also need to update your framework configuration with this: | ||
|
|
||
| ``` yaml |
There was a problem hiding this comment.
This is done automatically when using Flex. I'll drop this part.
core/getting-started.md
Outdated
| mapping: | ||
| paths: | ||
| - '%kernel.project_dir%/src/Entity' | ||
| - '%kernel.project_dir%/config/api_platform' |
There was a problem hiding this comment.
Can you add a comment explaining that this is only useful if you use XML or YAML?
GregoireHebert
force-pushed
the
yaml-groups
branch
from
136237f to
7659563
Compare
|
I rephrased the explanation above and add some comments on the configuration example. |
Simperfit
approved these changes
Apr 6, 2018
|
@dunglas could you please review that again ? |
|
ping @dunglas ;) |
|
Thanks @GregoireHebert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix api-platform/api-platform#184