Document identifier normalizers #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simperfit
reviewed
Apr 6, 2018
core/identifiers.md
Outdated
| # Identifiers | ||
|
|
||
| Every item operation has an identifier in it's URL. Although this identifier is usually a number, it can also be an `UUID`, a date, or the type of your choice. | ||
| To help with your developer experience, we introduced an identifier normalization process. |
There was a problem hiding this comment.
developer -> development ?
soyuka
force-pushed
the
identifier-normalizer
branch
from
d607e6a to
4571ffb
Compare
Simperfit
approved these changes
Apr 6, 2018
|
Thanks @soyuka! |
antograssiot
reviewed
Apr 6, 2018
| public function getItem(string $resourceClass, $identifiers, string $operationName = null, array $context = []) | ||
| { | ||
| // Our identifier is: | ||
| // $id['code'] |
There was a problem hiding this comment.
$identifiers instead of $id ?
Here and bellow...
There was a problem hiding this comment.
Yes ! This is why I wanted some reviews before @Simperfit merged :p now he will fix it because he said he took full responsability :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.