[GraphQL] Security #471
Merged
[GraphQL] Security #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
reviewed
Apr 23, 2018
core/graphql.md
Outdated
| If your security needs differ between REST and GraphQL, add the particular parts in the `graphql` key. | ||
|
|
||
| In the example below, we want the same security rules as in REST, but we also want to allow an admin to delete a book in GraphQL only. | ||
| Please note it's not possible to update a book in GraphQL because the operation is not defined. |
There was a problem hiding this comment.
Please note that ... because the operation update is not enabled defined.
soyuka
approved these changes
Apr 23, 2018
dunglas
requested changes
Apr 24, 2018
core/graphql.md
Outdated
| @@ -59,7 +60,10 @@ use ApiPlatform\Core\Annotation\ApiResource; | |||
| * graphql={ | |||
| * "query"={ | |||
| * "filters"={"offer.date_filter"} | |||
| * } | |||
| * }, | |||
| * "delete"={}, | |||
There was a problem hiding this comment.
The syntax "delete", "update", "create" should work IIRC.
core/graphql.md
Outdated
| @@ -68,3 +72,42 @@ class Offer | |||
| // ... | |||
| } | |||
| ``` | |||
|
|
|||
| ## Security (access_control) | |||
alanpoulain
force-pushed
the
graphql-security
branch
from
a27b1b5 to
61f4461
Compare
|
Fixed. |
|
thanks @alanpoulain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.