Skip to content

Commit 6af412e

Browse files
Test against Node v22 (#7903)
Update CCI config to test against Node 22 as well
1 parent 86d7111 commit 6af412e

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

.changeset/seven-brooms-impress.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
---
2+
---

.circleci/config.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,7 @@ workflows:
144144
- "16"
145145
- "18"
146146
- "20"
147+
- "22"
147148
- "Check for FIXM\x45"
148149
- Prettier
149150
- ESLint

packages/server/src/__tests__/plugin/drainHttpServer/stoppable.test.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -141,12 +141,8 @@ Object.keys(schemes).forEach((schemeName) => {
141141
// idle connections in these versions. However, `Stopper` _is_ still
142142
// useful for gracefully finishing in-flight requests within the timeout
143143
// (and aborting requests beyond the timeout).
144-
//
145-
// (Node 18.19.0 had this change backported but it was removed again in
146-
// 18.20.3; our tests only pin major versions so we can assume 18 means
147-
// >= 18.20.3.)
148-
const isNode20 = !!process.version.match(/^v20\./);
149-
expect(closed).toBe(isNode20 ? 1 : 0);
144+
const isNode20orGreater = !!process.version.match(/^v2\d\./);
145+
expect(closed).toBe(isNode20orGreater ? 1 : 0);
150146
});
151147

152148
// This test specifically added for Node 20 fails for Node 14. Just going

0 commit comments

Comments
 (0)