Fix use of deprecated datetime.utcnow() function #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function has been deprecated in Python 3.12, as seen in this warning:
```
/usr/local/lib/python3.12/site-packages/appstoreserverlibrary/api\_client.py:469: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).
future\_time = datetime.datetime.utcnow() + datetime.timedelta(minutes=5)
```
You can see that warning when running the tests in this repository with a sufficiently new Python (`python3 -m unittest`). Luckily the replacement has been available for a while! I've used datetime.timezone.utc instead of datetime.UTC because that alias was only introduced in 3.11.
WFT
added a commit
to WFT/app-store-server-library-python
that referenced
this pull request
Jun 6, 2024
This use of the cryptography package generates a warning, seen below. ``` /Users/Will/dev/forks/app-store-server-library-python/tests/util.py:22: CryptographyDeprecationWarning: Curve argument must be an instance of an EllipticCurve class. Did you pass a class by mistake? This will be an exception in a future version of cryptography. public_key = ec.generate_private_key(ec.SECP256R1).public_key().public_bytes(encoding=serialization.Encoding.PEM, format=serialization.PublicFormat.SubjectPublicKeyInfo).decode() ``` I noticed this while preparing apple#93 & thought I'd toss this up as well. It passes the tests on my local machine, now without this warning.
alexanderjordanbaker
approved these changes
Jun 9, 2024
|
Sure thing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! When using this library with Python 3.12, you get a deprecation warning. Luckily it's easily fixed.
The warning:
You can see that warning when running the tests in this repository with a sufficiently new Python (
python3 -m unittest). Luckily the replacement is easy. I've useddatetime.timezone.utcinstead ofdatetime.UTCbecause that alias was only introduced in 3.11.