[CodeReview] Making the corrections

Author: LucianoPAlmeida

Sources/Algorithms/Compacted.swift

@@ -175,8 +175,6 @@ extension Collection {
 extension CompactedSequence: LazySequenceProtocol
   where Base: LazySequenceProtocol {}
 
-extension CompactedCollection: RandomAccessCollection
-  where Base: RandomAccessCollection {}
 extension CompactedCollection: LazySequenceProtocol
   where Base: LazySequenceProtocol {}
 extension CompactedCollection: LazyCollectionProtocol

Tests/SwiftAlgorithmsTests/CompactedTests.swift

@@ -38,7 +38,7 @@ final class CompactedTests: XCTestCase {
 
   func testCollectionTraversals() {
     for array in self.tests {
-      validateIndexTraversals(array)
+      validateIndexTraversals(array.compacted())
     }
   }
 
@@ -55,14 +55,26 @@ final class CompactedTests: XCTestCase {
   }
 
   func testCollectionHashableConformances() {
-    for array in self.tests {
-      let seq = array.eraseToAnyHashableSequence()
-      XCTAssertEqualHashValue(
-        seq.compacted(), seq.compactMap({ $0 }).compacted()
-      )
-      XCTAssertEqualHashValue(
-        array.compacted(), array.compactMap({ $0 }).compacted()
-      )
+    for array1 in self.tests {
+      for array2 in self.tests {
+        // Collections and Sequences that produce the same
+        // elements should produce the same hash. e.g.
+        // [1, 2, 3, nil, nil, 4].compacted() should produce
+        // the same hash as [1, nil, 2, nil, 3, 4].compacted()
+        guard array1.compacted() == array2.compacted() else {
+          continue
+        }
+        
+        let seq = array1.eraseToAnyHashableSequence()
+        let seq2 = array2.eraseToAnyHashableSequence()
+        
+        XCTAssertEqualHashValue(
+          seq.compacted(), seq2.compacted()
+        )
+        XCTAssertEqualHashValue(
+          array1.compacted(), array2.compacted()
+        )
+      }
     }
   }
 }