Skip to content
This repository was archived by the owner on Mar 28, 2020. It is now read-only.

Commit 24ec170

Browse files
Matt DavisMatt Davis
authored andcommitted
[llvm-mca] Remove unused InstRef formal from pre and post execute callbacks. NFC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@337077 91177308-0d34-0410-b5e6-96231b3b80d8
1 parent d0c165b commit 24ec170

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

tools/llvm-mca/FetchStage.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ bool FetchStage::execute(InstRef &IR) {
2929
return true;
3030
}
3131

32-
void FetchStage::postExecute(const InstRef &IR) { SM.updateNext(); }
32+
void FetchStage::postExecute() { SM.updateNext(); }
3333

3434
void FetchStage::cycleEnd() {
3535
// Find the first instruction which hasn't been retired.

tools/llvm-mca/FetchStage.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class FetchStage : public Stage {
3636

3737
bool hasWorkToComplete() const override final;
3838
bool execute(InstRef &IR) override final;
39-
void postExecute(const InstRef &IR) override final;
39+
void postExecute() override final;
4040
void cycleEnd() override final;
4141
};
4242

tools/llvm-mca/Pipeline.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,14 +47,14 @@ bool Pipeline::executeStages(InstRef &IR) {
4747
return true;
4848
}
4949

50-
void Pipeline::preExecuteStages(const InstRef &IR) {
50+
void Pipeline::preExecuteStages() {
5151
for (const std::unique_ptr<Stage> &S : Stages)
52-
S->preExecute(IR);
52+
S->preExecute();
5353
}
5454

55-
void Pipeline::postExecuteStages(const InstRef &IR) {
55+
void Pipeline::postExecuteStages() {
5656
for (const std::unique_ptr<Stage> &S : Stages)
57-
S->postExecute(IR);
57+
S->postExecute();
5858
}
5959

6060
void Pipeline::run() {
@@ -75,10 +75,10 @@ void Pipeline::runCycle() {
7575
// Continue executing this cycle until any stage claims it cannot make
7676
// progress.
7777
while (true) {
78-
preExecuteStages(IR);
78+
preExecuteStages();
7979
if (!executeStages(IR))
8080
break;
81-
postExecuteStages(IR);
81+
postExecuteStages();
8282
}
8383

8484
for (auto &S : Stages)

tools/llvm-mca/Pipeline.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,9 @@ class Pipeline {
5959
std::set<HWEventListener *> Listeners;
6060
unsigned Cycles;
6161

62-
void preExecuteStages(const InstRef &IR);
62+
void preExecuteStages();
6363
bool executeStages(InstRef &IR);
64-
void postExecuteStages(const InstRef &IR);
64+
void postExecuteStages();
6565
void runCycle();
6666

6767
bool hasWorkToProcess();

tools/llvm-mca/Stage.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,12 +50,12 @@ class Stage {
5050

5151
/// Called prior to executing the list of stages.
5252
/// This can be called multiple times per cycle.
53-
virtual void preExecute(const InstRef &IR) {}
53+
virtual void preExecute() {}
5454

5555
/// Called as a cleanup and finalization phase after each execution.
5656
/// This will only be called if all stages return a success from their
5757
/// execute callback. This can be called multiple times per cycle.
58-
virtual void postExecute(const InstRef &IR) {}
58+
virtual void postExecute() {}
5959

6060
/// The primary action that this stage performs.
6161
/// Returning false prevents successor stages from having their 'execute'

0 commit comments

Comments
 (0)