Skip to content
This repository was archived by the owner on Mar 28, 2020. It is now read-only.

Commit 460ff94

Browse files
committed
AMDGPU/R600: Cleanup DAGCombine
Move SDLoc initialization to comon place. fall back to AMDGPU version in one place Differential Revision: https://reviews.llvm.org/D23900 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@280030 91177308-0d34-0410-b5e6-96231b3b80d8
1 parent 908f420 commit 460ff94

File tree

1 file changed

+12
-15
lines changed

1 file changed

+12
-15
lines changed

lib/Target/AMDGPU/R600ISelLowering.cpp

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1706,14 +1706,14 @@ SDValue R600TargetLowering::OptimizeSwizzle(SDValue BuildVector, SDValue Swz[4],
17061706
SDValue R600TargetLowering::PerformDAGCombine(SDNode *N,
17071707
DAGCombinerInfo &DCI) const {
17081708
SelectionDAG &DAG = DCI.DAG;
1709+
SDLoc DL(N);
17091710

17101711
switch (N->getOpcode()) {
1711-
default: return AMDGPUTargetLowering::PerformDAGCombine(N, DCI);
17121712
// (f32 fp_round (f64 uint_to_fp a)) -> (f32 uint_to_fp a)
17131713
case ISD::FP_ROUND: {
17141714
SDValue Arg = N->getOperand(0);
17151715
if (Arg.getOpcode() == ISD::UINT_TO_FP && Arg.getValueType() == MVT::f64) {
1716-
return DAG.getNode(ISD::UINT_TO_FP, SDLoc(N), N->getValueType(0),
1716+
return DAG.getNode(ISD::UINT_TO_FP, DL, N->getValueType(0),
17171717
Arg.getOperand(0));
17181718
}
17191719
break;
@@ -1738,12 +1738,11 @@ SDValue R600TargetLowering::PerformDAGCombine(SDNode *N,
17381738
return SDValue();
17391739
}
17401740

1741-
SDLoc dl(N);
1742-
return DAG.getNode(ISD::SELECT_CC, dl, N->getValueType(0),
1741+
return DAG.getNode(ISD::SELECT_CC, DL, N->getValueType(0),
17431742
SelectCC.getOperand(0), // LHS
17441743
SelectCC.getOperand(1), // RHS
1745-
DAG.getConstant(-1, dl, MVT::i32), // True
1746-
DAG.getConstant(0, dl, MVT::i32), // False
1744+
DAG.getConstant(-1, DL, MVT::i32), // True
1745+
DAG.getConstant(0, DL, MVT::i32), // False
17471746
SelectCC.getOperand(4)); // CC
17481747

17491748
break;
@@ -1755,7 +1754,6 @@ SDValue R600TargetLowering::PerformDAGCombine(SDNode *N,
17551754
SDValue InVec = N->getOperand(0);
17561755
SDValue InVal = N->getOperand(1);
17571756
SDValue EltNo = N->getOperand(2);
1758-
SDLoc dl(N);
17591757

17601758
// If the inserted element is an UNDEF, just use the input vector.
17611759
if (InVal.isUndef())
@@ -1793,13 +1791,13 @@ SDValue R600TargetLowering::PerformDAGCombine(SDNode *N,
17931791
EVT OpVT = Ops[0].getValueType();
17941792
if (InVal.getValueType() != OpVT)
17951793
InVal = OpVT.bitsGT(InVal.getValueType()) ?
1796-
DAG.getNode(ISD::ANY_EXTEND, dl, OpVT, InVal) :
1797-
DAG.getNode(ISD::TRUNCATE, dl, OpVT, InVal);
1794+
DAG.getNode(ISD::ANY_EXTEND, DL, OpVT, InVal) :
1795+
DAG.getNode(ISD::TRUNCATE, DL, OpVT, InVal);
17981796
Ops[Elt] = InVal;
17991797
}
18001798

18011799
// Return the new vector
1802-
return DAG.getBuildVector(VT, dl, Ops);
1800+
return DAG.getBuildVector(VT, DL, Ops);
18031801
}
18041802

18051803
// Extract_vec (Build_vector) generated by custom lowering
@@ -1816,8 +1814,8 @@ SDValue R600TargetLowering::PerformDAGCombine(SDNode *N,
18161814
Arg.getOperand(0).getOpcode() == ISD::BUILD_VECTOR) {
18171815
if (ConstantSDNode *Const = dyn_cast<ConstantSDNode>(N->getOperand(1))) {
18181816
unsigned Element = Const->getZExtValue();
1819-
return DAG.getNode(ISD::BITCAST, SDLoc(N), N->getVTList(),
1820-
Arg->getOperand(0).getOperand(Element));
1817+
return DAG.getNode(ISD::BITCAST, DL, N->getVTList(),
1818+
Arg->getOperand(0).getOperand(Element));
18211819
}
18221820
}
18231821
break;
@@ -1858,7 +1856,7 @@ SDValue R600TargetLowering::PerformDAGCombine(SDNode *N,
18581856
LHS.getOperand(0).getValueType().isInteger());
18591857
if (DCI.isBeforeLegalizeOps() ||
18601858
isCondCodeLegal(LHSCC, LHS.getOperand(0).getSimpleValueType()))
1861-
return DAG.getSelectCC(SDLoc(N),
1859+
return DAG.getSelectCC(DL,
18621860
LHS.getOperand(0),
18631861
LHS.getOperand(1),
18641862
LHS.getOperand(2),
@@ -1885,7 +1883,6 @@ SDValue R600TargetLowering::PerformDAGCombine(SDNode *N,
18851883
N->getOperand(6), // SWZ_Z
18861884
N->getOperand(7) // SWZ_W
18871885
};
1888-
SDLoc DL(N);
18891886
NewArgs[1] = OptimizeSwizzle(N->getOperand(1), &NewArgs[4], DAG, DL);
18901887
return DAG.getNode(AMDGPUISD::EXPORT, DL, N->getVTList(), NewArgs);
18911888
}
@@ -1915,10 +1912,10 @@ SDValue R600TargetLowering::PerformDAGCombine(SDNode *N,
19151912
N->getOperand(17),
19161913
N->getOperand(18),
19171914
};
1918-
SDLoc DL(N);
19191915
NewArgs[1] = OptimizeSwizzle(N->getOperand(1), &NewArgs[2], DAG, DL);
19201916
return DAG.getNode(AMDGPUISD::TEXTURE_FETCH, DL, N->getVTList(), NewArgs);
19211917
}
1918+
default: break;
19221919
}
19231920

19241921
return AMDGPUTargetLowering::PerformDAGCombine(N, DCI);

0 commit comments

Comments
 (0)