Skip to content
This repository was archived by the owner on Mar 28, 2020. It is now read-only.

Commit 466ce67

Browse files
author
Aleksandr Urakov
committed
Revert "[PDB] Extend IPDBSession's interface to retrieve frame data"
This reverts commit b5c7e2f. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@344909 91177308-0d34-0410-b5e6-96231b3b80d8
1 parent affca96 commit 466ce67

File tree

14 files changed

+0
-247
lines changed

14 files changed

+0
-247
lines changed

include/llvm/DebugInfo/PDB/DIA/DIAEnumFrameData.h

Lines changed: 0 additions & 40 deletions
This file was deleted.

include/llvm/DebugInfo/PDB/DIA/DIAFrameData.h

Lines changed: 0 additions & 41 deletions
This file was deleted.

include/llvm/DebugInfo/PDB/DIA/DIASession.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@ class DIASession : public IPDBSession {
8585

8686
std::unique_ptr<IPDBEnumSectionContribs> getSectionContribs() const override;
8787

88-
std::unique_ptr<IPDBEnumFrameData> getFrameData() const override;
8988
private:
9089
CComPtr<IDiaSession> Session;
9190
};

include/llvm/DebugInfo/PDB/IPDBFrameData.h

Lines changed: 0 additions & 36 deletions
This file was deleted.

include/llvm/DebugInfo/PDB/IPDBSession.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,6 @@ class IPDBSession {
9191

9292
virtual std::unique_ptr<IPDBEnumSectionContribs>
9393
getSectionContribs() const = 0;
94-
95-
virtual std::unique_ptr<IPDBEnumFrameData>
96-
getFrameData() const = 0;
9794
};
9895
} // namespace pdb
9996
} // namespace llvm

include/llvm/DebugInfo/PDB/Native/NativeSession.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,6 @@ class NativeSession : public IPDBSession {
9393

9494
std::unique_ptr<IPDBEnumSectionContribs> getSectionContribs() const override;
9595

96-
std::unique_ptr<IPDBEnumFrameData> getFrameData() const override;
97-
9896
PDBFile &getPDBFile() { return *Pdb; }
9997
const PDBFile &getPDBFile() const { return *Pdb; }
10098

include/llvm/DebugInfo/PDB/PDBTypes.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212

1313
#include "llvm/DebugInfo/CodeView/CodeView.h"
1414
#include "llvm/DebugInfo/PDB/IPDBEnumChildren.h"
15-
#include "llvm/DebugInfo/PDB/IPDBFrameData.h"
1615
#include "llvm/DebugInfo/PDB/Native/RawTypes.h"
1716
#include <cctype>
1817
#include <cstddef>
@@ -72,7 +71,6 @@ using IPDBEnumLineNumbers = IPDBEnumChildren<IPDBLineNumber>;
7271
using IPDBEnumTables = IPDBEnumChildren<IPDBTable>;
7372
using IPDBEnumInjectedSources = IPDBEnumChildren<IPDBInjectedSource>;
7473
using IPDBEnumSectionContribs = IPDBEnumChildren<IPDBSectionContrib>;
75-
using IPDBEnumFrameData = IPDBEnumChildren<IPDBFrameData>;
7674

7775
/// Specifies which PDB reader implementation is to be used. Only a value
7876
/// of PDB_ReaderType::DIA is currently supported, but Native is in the works.

lib/DebugInfo/PDB/CMakeLists.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,13 @@ if(LLVM_ENABLE_DIA_SDK)
1414
add_pdb_impl_folder(DIA
1515
DIA/DIADataStream.cpp
1616
DIA/DIAEnumDebugStreams.cpp
17-
DIA/DIAEnumFrameData.cpp
1817
DIA/DIAEnumInjectedSources.cpp
1918
DIA/DIAEnumLineNumbers.cpp
2019
DIA/DIAEnumSectionContribs.cpp
2120
DIA/DIAEnumSourceFiles.cpp
2221
DIA/DIAEnumSymbols.cpp
2322
DIA/DIAEnumTables.cpp
2423
DIA/DIAError.cpp
25-
DIA/DIAFrameData.cpp
2624
DIA/DIAInjectedSource.cpp
2725
DIA/DIALineNumber.cpp
2826
DIA/DIARawSymbol.cpp

lib/DebugInfo/PDB/DIA/DIAEnumFrameData.cpp

Lines changed: 0 additions & 43 deletions
This file was deleted.

lib/DebugInfo/PDB/DIA/DIAFrameData.cpp

Lines changed: 0 additions & 54 deletions
This file was deleted.

lib/DebugInfo/PDB/DIA/DIASession.cpp

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#include "llvm/DebugInfo/PDB/DIA/DIASession.h"
1010
#include "llvm/ADT/STLExtras.h"
1111
#include "llvm/DebugInfo/PDB/DIA/DIAEnumDebugStreams.h"
12-
#include "llvm/DebugInfo/PDB/DIA/DIAEnumFrameData.h"
1312
#include "llvm/DebugInfo/PDB/DIA/DIAEnumInjectedSources.h"
1413
#include "llvm/DebugInfo/PDB/DIA/DIAEnumLineNumbers.h"
1514
#include "llvm/DebugInfo/PDB/DIA/DIAEnumSectionContribs.h"
@@ -420,13 +419,3 @@ DIASession::getSectionContribs() const {
420419

421420
return llvm::make_unique<DIAEnumSectionContribs>(*this, Sections);
422421
}
423-
424-
std::unique_ptr<IPDBEnumFrameData>
425-
DIASession::getFrameData() const {
426-
CComPtr<IDiaEnumFrameData> FD =
427-
getTableEnumerator<IDiaEnumFrameData>(*Session);
428-
if (!FD)
429-
return nullptr;
430-
431-
return llvm::make_unique<DIAEnumFrameData>(*this, FD);
432-
}

lib/DebugInfo/PDB/Native/NativeSession.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -200,11 +200,6 @@ NativeSession::getSectionContribs() const {
200200
return nullptr;
201201
}
202202

203-
std::unique_ptr<IPDBEnumFrameData>
204-
NativeSession::getFrameData() const {
205-
return nullptr;
206-
}
207-
208203
void NativeSession::initializeExeSymbol() {
209204
if (ExeSymbol == 0)
210205
ExeSymbol = Cache.createSymbol<NativeExeSymbol>();

lib/DebugInfo/PDB/PDBInterfaceAnchors.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
//===----------------------------------------------------------------------===//
1313

1414
#include "llvm/DebugInfo/PDB/IPDBDataStream.h"
15-
#include "llvm/DebugInfo/PDB/IPDBFrameData.h"
1615
#include "llvm/DebugInfo/PDB/IPDBInjectedSource.h"
1716
#include "llvm/DebugInfo/PDB/IPDBLineNumber.h"
1817
#include "llvm/DebugInfo/PDB/IPDBRawSymbol.h"
@@ -36,5 +35,3 @@ IPDBTable::~IPDBTable() = default;
3635
IPDBInjectedSource::~IPDBInjectedSource() = default;
3736

3837
IPDBSectionContrib::~IPDBSectionContrib() = default;
39-
40-
IPDBFrameData::~IPDBFrameData() = default;

unittests/DebugInfo/PDB/PDBApiTest.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -159,10 +159,6 @@ class MockSession : public IPDBSession {
159159
std::unique_ptr<IPDBEnumSectionContribs> getSectionContribs() const override {
160160
return nullptr;
161161
}
162-
163-
std::unique_ptr<IPDBEnumFrameData> getFrameData() const override {
164-
return nullptr;
165-
}
166162
};
167163

168164
class MockRawSymbol : public IPDBRawSymbol {

0 commit comments

Comments
 (0)