[llvm-exegesis] Crash when assembling invalid Operand

gchatelet · gchatelet · commit 502027b71971 · 2018-10-22T15:06:10.000Z
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@344907 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/tools/llvm-exegesis/lib/Assembler.cpp b/tools/llvm-exegesis/lib/Assembler.cpp
@@ -110,6 +110,8 @@ static void fillMachineFunction(llvm::MachineFunction &MF,
         Builder.addReg(Op.getReg(), Flags);
       } else if (Op.isImm()) {
         Builder.addImm(Op.getImm());
+      } else if (!Op.isValid()) {
+        llvm_unreachable("Operand is not set");
       } else {
         llvm_unreachable("Not yet implemented");
       }

Original file line number	Diff line number	Diff line change
`@@ -110,6 +110,8 @@ static void fillMachineFunction(llvm::MachineFunction &MF,`
`110`	`110`	`Builder.addReg(Op.getReg(), Flags);`
`111`	`111`	`} else if (Op.isImm()) {`
`112`	`112`	`Builder.addImm(Op.getImm());`
	`113`	`+ } else if (!Op.isValid()) {`
	`114`	`+ llvm_unreachable("Operand is not set");`
`113`	`115`	`} else {`
`114`	`116`	`llvm_unreachable("Not yet implemented");`
`115`	`117`	`}`