Skip to content
This repository was archived by the owner on Mar 28, 2020. It is now read-only.

Commit 77b5e46

Browse files
committed
[WebAssembly] Return ArrayRef's rather than const std::vector&
From working on lld I've learned this is generally the preferred way for several reasons (e.g. more concise, improves encapsulation). Differential Revision: https://reviews.llvm.org/D41265 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@320906 91177308-0d34-0410-b5e6-96231b3b80d8
1 parent ef76fcd commit 77b5e46

File tree

1 file changed

+11
-21
lines changed

1 file changed

+11
-21
lines changed

include/llvm/Object/Wasm.h

Lines changed: 11 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -128,28 +128,18 @@ class WasmObjectFile : public ObjectFile {
128128

129129
static bool classof(const Binary *v) { return v->isWasm(); }
130130

131-
const std::vector<wasm::WasmSignature>& types() const { return Signatures; }
132-
const std::vector<uint32_t>& functionTypes() const { return FunctionTypes; }
133-
const std::vector<wasm::WasmImport>& imports() const { return Imports; }
134-
const std::vector<wasm::WasmTable>& tables() const { return Tables; }
135-
const std::vector<wasm::WasmLimits>& memories() const { return Memories; }
136-
const std::vector<wasm::WasmGlobal>& globals() const { return Globals; }
137-
const std::vector<wasm::WasmExport>& exports() const { return Exports; }
131+
ArrayRef<wasm::WasmSignature> types() const { return Signatures; }
132+
ArrayRef<uint32_t> functionTypes() const { return FunctionTypes; }
133+
ArrayRef<wasm::WasmImport> imports() const { return Imports; }
134+
ArrayRef<wasm::WasmTable> tables() const { return Tables; }
135+
ArrayRef<wasm::WasmLimits> memories() const { return Memories; }
136+
ArrayRef<wasm::WasmGlobal> globals() const { return Globals; }
137+
ArrayRef<wasm::WasmExport> exports() const { return Exports; }
138138
const wasm::WasmLinkingData& linkingData() const { return LinkingData; }
139-
140-
uint32_t getNumberOfSymbols() const {
141-
return Symbols.size();
142-
}
143-
144-
const std::vector<wasm::WasmElemSegment>& elements() const {
145-
return ElemSegments;
146-
}
147-
148-
const std::vector<WasmSegment>& dataSegments() const {
149-
return DataSegments;
150-
}
151-
152-
const std::vector<wasm::WasmFunction>& functions() const { return Functions; }
139+
uint32_t getNumberOfSymbols() const { return Symbols.size(); }
140+
ArrayRef<wasm::WasmElemSegment> elements() const { return ElemSegments; }
141+
ArrayRef<WasmSegment> dataSegments() const { return DataSegments; }
142+
ArrayRef<wasm::WasmFunction> functions() const { return Functions; }
153143
const ArrayRef<uint8_t>& code() const { return CodeSection; }
154144
uint32_t startFunction() const { return StartFunction; }
155145

0 commit comments

Comments
 (0)