Skip to content
This repository was archived by the owner on Mar 28, 2020. It is now read-only.

Commit d9e1a18

Browse files
author
Mandeep Singh Grang
committed
[AArch64] Make assert messages uniform and general [NFC]
Summary: Make assert messages related to Darwin, ELF and COFF uniform. Reviewers: rnk, ruiu, compnerd, t.p.northover Reviewed By: t.p.northover Subscribers: t.p.northover, aemerson, rengolin, javed.absar, llvm-commits, kristof.beyls Differential Revision: https://reviews.llvm.org/D34730 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@306589 91177308-0d34-0410-b5e6-96231b3b80d8
1 parent f340eac commit d9e1a18

File tree

4 files changed

+5
-8
lines changed

4 files changed

+5
-8
lines changed

lib/Target/AArch64/AArch64MCInstLower.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,8 +168,7 @@ MCOperand AArch64MCInstLower::LowerSymbolOperand(const MachineOperand &MO,
168168
if (Printer.TM.getTargetTriple().isOSBinFormatCOFF())
169169
return lowerSymbolOperandCOFF(MO, Sym);
170170

171-
assert(Printer.TM.getTargetTriple().isOSBinFormatELF() &&
172-
"Expect Darwin, ELF or COFF target");
171+
assert(Printer.TM.getTargetTriple().isOSBinFormatELF() && "Invalid target");
173172
return lowerSymbolOperandELF(MO, Sym);
174173
}
175174

lib/Target/AArch64/AArch64RegisterInfo.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ const uint32_t *AArch64RegisterInfo::getTLSCallPreservedMask() const {
9494
if (TT.isOSDarwin())
9595
return CSR_AArch64_TLS_Darwin_RegMask;
9696

97-
assert(TT.isOSBinFormatELF() && "only expect Darwin or ELF TLS");
97+
assert(TT.isOSBinFormatELF() && "Invalid target");
9898
return CSR_AArch64_TLS_ELF_RegMask;
9999
}
100100

lib/Target/AArch64/MCTargetDesc/AArch64AsmBackend.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -590,8 +590,7 @@ MCAsmBackend *llvm::createAArch64leAsmBackend(const Target &T,
590590
if (TheTriple.isOSBinFormatCOFF())
591591
return new COFFAArch64AsmBackend(T, TheTriple);
592592

593-
assert(TheTriple.isOSBinFormatELF() &&
594-
"Expect either MachO, ELF or COFF target");
593+
assert(TheTriple.isOSBinFormatELF() && "Invalid target");
595594

596595
uint8_t OSABI = MCELFObjectTargetWriter::getOSABI(TheTriple.getOS());
597596
bool IsILP32 = Options.getABIName() == "ilp32";

lib/Target/AArch64/MCTargetDesc/AArch64MCTargetDesc.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ static MCAsmInfo *createAArch64MCAsmInfo(const MCRegisterInfo &MRI,
6363
else if (TheTriple.isOSBinFormatCOFF())
6464
MAI = new AArch64MCAsmInfoCOFF();
6565
else {
66-
assert(TheTriple.isOSBinFormatELF() && "Only expect Darwin, ELF or COFF");
66+
assert(TheTriple.isOSBinFormatELF() && "Invalid target");
6767
MAI = new AArch64MCAsmInfoELF(TheTriple);
6868
}
6969

@@ -78,8 +78,7 @@ static MCAsmInfo *createAArch64MCAsmInfo(const MCRegisterInfo &MRI,
7878
static void adjustCodeGenOpts(const Triple &TT, Reloc::Model RM,
7979
CodeModel::Model &CM) {
8080
assert((TT.isOSBinFormatELF() || TT.isOSBinFormatMachO() ||
81-
TT.isOSBinFormatCOFF()) &&
82-
"Only expect Darwin, ELF and COFF targets");
81+
TT.isOSBinFormatCOFF()) && "Invalid target");
8382

8483
if (CM == CodeModel::Default)
8584
CM = CodeModel::Small;

0 commit comments

Comments
 (0)